Repository navigation
Deactivate nostr backups, lendaswap, and lendasat announcements - #368
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThree announcements were marked Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The restoreWallet helper was doing a hard wait on the "Maybe later" button from the announcement banner. Now that all announcements are disabled, this button never appears, causing test timeouts. Updated to use the same graceful pattern as createWallet. https://claude.ai/code/session_011DiNjK728A5gXHD9w8TXiN
Deploying wallet-mutinynet with
|
| Latest commit: |
58bcdb9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://27496408.arkade-wallet.pages.dev |
| Branch Preview URL: | https://claude-disable-news-banner-0.arkade-wallet.pages.dev |
Deploying wallet-bitcoin with
|
| Latest commit: |
58bcdb9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b810da21.wallet-bitcoin.pages.dev |
| Branch Preview URL: | https://claude-disable-news-banner-0.wallet-bitcoin.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/test/e2e/utils.ts (1)
117-122: Extract the “Maybe later” dismissal into a shared helper.This block duplicates the same logic already used in
createWallet, which can drift over time. Consider centralizing it in one helper and calling it from both flows.♻️ Suggested refactor
export async function createWallet(page: Page): Promise<void> { await page.goto('/') await page.getByText('Continue').click() await page.getByText('Continue').click() await page.getByText('Continue').click() await page.getByText('Skip for now').click() await page.getByText('+ Create wallet').click() await page.waitForSelector('text=Your new wallet is live!', { state: 'visible' }) await page.getByText('Go to wallet').click() - const maybeLater = page.getByRole('button', { name: 'Maybe later' }) - await maybeLater.waitFor({ state: 'visible', timeout: 15000 }).catch(() => {}) - if (await maybeLater.isVisible()) { - await maybeLater.click({ force: true }) - await maybeLater.waitFor({ state: 'hidden' }).catch(() => {}) - } + await dismissMaybeLaterIfVisible(page) } @@ async function restoreWallet(page: Page, nsec: string): Promise<void> { @@ await page.getByText('Continue').click() await page.getByText('Go to wallet').click() - const maybeLater = page.getByRole('button', { name: 'Maybe later' }) - await maybeLater.waitFor({ state: 'visible', timeout: 15000 }).catch(() => {}) - if (await maybeLater.isVisible()) { - await maybeLater.click({ force: true }) - await maybeLater.waitFor({ state: 'hidden' }).catch(() => {}) - } + await dismissMaybeLaterIfVisible(page) } + +async function dismissMaybeLaterIfVisible(page: Page): Promise<void> { + const maybeLater = page.getByRole('button', { name: 'Maybe later' }) + await maybeLater.waitFor({ state: 'visible', timeout: 15000 }).catch(() => {}) + if (await maybeLater.isVisible()) { + await maybeLater.click({ force: true }) + await maybeLater.waitFor({ state: 'hidden' }).catch(() => {}) + } +}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/test/e2e/utils.ts` around lines 117 - 122, Extract the repeated "Maybe later" dismissal logic into a single helper function (e.g., dismissMaybeLaterIfVisible) that accepts the Playwright Page, performs getByRole('button', { name: 'Maybe later' }), waits up to 15s for visibility, clicks if visible with force, and waits for hidden, swallowing expected errors; replace the duplicate block in utils.ts and the similar code in createWallet to call this new helper so both flows share one implementation.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/test/e2e/utils.ts`:
- Around line 117-122: Extract the repeated "Maybe later" dismissal logic into a
single helper function (e.g., dismissMaybeLaterIfVisible) that accepts the
Playwright Page, performs getByRole('button', { name: 'Maybe later' }), waits up
to 15s for visibility, clicks if visible with force, and waits for hidden,
swallowing expected errors; replace the duplicate block in utils.ts and the
similar code in createWallet to call this new helper so both flows share one
implementation.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: aec1b953-dd85-4ec5-9824-534d7de7d843
📒 Files selected for processing (1)
src/test/e2e/utils.ts
bordalix
reviewed
Mar 5, 2026
Co-authored-by: João Bordalo <bordalix@users.noreply.github.com> Signed-off-by: Marco Argentieri <3596602+tiero@users.noreply.github.com>
Kukks
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change deactivates three announcement items by marking them as inactive, preventing them from being displayed to users.
Changes
Details
All three announcements now have the
inactive: trueflag set, which will prevent them from being rendered in the announcements provider. The 'boltz' announcement was already marked as inactive and remains unchanged.https://claude.ai/code/session_011DiNjK728A5gXHD9w8TXiN
Summary by CodeRabbit
Updates
Tests