Handle ServiceWorker lifecycle by pietro909 · Pull Request #357 · arkade-os/wallet

pietro909 · 2026-03-04T05:29:57Z

Summary by CodeRabbit

Release Notes

Chores
- Updated arkade-os boltz-swap and SDK dependencies to latest pre-release versions.
- Updated project configuration files.
Bug Fixes
- Wallet lock now properly clears background status monitoring intervals.
Refactor
- Modified service worker activation to support manual updates and streamlined cache cleanup.

cloudflare-workers-and-pages · 2026-03-04T05:30:07Z

Deploying wallet-bitcoin with Cloudflare Pages

Latest commit:	`1bd3a4a`
Status:	✅ Deploy successful!
Preview URL:	https://dcebfb55.wallet-bitcoin.pages.dev
Branch Preview URL:	https://handle-sw-lifecycle.wallet-bitcoin.pages.dev

View logs

coderabbitai · 2026-03-04T05:30:07Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

next-version

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 71b92221-5912-4855-9edb-6972b35285f3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Walkthrough

The PR updates pre-release dependency versions, adds status ping interval cleanup to wallet lock logic, and refactors service worker activation to support skip-waiting triggering instead of forcing client page reloads.

Changes

Cohort / File(s)	Summary
Configuration & Dependencies `.gitignore`, `package.json`	Added TASKS.md to ignore entries; bumped `@arkade-os/boltz-swap` to 0.3.0-next.2 and `@arkade-os/sdk` to 0.4.0-next.4.
Wallet Provider `src/providers/wallet.tsx`	Added logic in `lockWallet` to clear the status ping interval if it exists, preventing ongoing wallet status pings after lock.
Service Worker `src/wallet-service-worker.ts`	Replaced forced client reload mechanism with a SKIP_WAITING message listener to trigger `self.skipWaiting()`. Activation now only performs cache cleanup and claims clients without broadcasting reload messages.

Sequence Diagram(s)

sequenceDiagram
    participant Client as Client/App
    participant SW as Service Worker
    participant Cache as Cache Storage

    rect rgba(100, 150, 200, 0.5)
    Note over Client,Cache: New Service Worker Activation Flow
    Client->>SW: Send SKIP_WAITING message
    activate SW
    SW->>SW: self.skipWaiting()
    end
    
    rect rgba(150, 200, 100, 0.5)
    Note over Client,Cache: Activation Event
    SW->>Cache: Clean up old caches
    SW->>SW: Claim all clients
    SW-->>Client: Ready for new version
    deactivate SW
    end

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Possibly related PRs

PR #342 — Modifies the same files (package.json, src/providers/wallet.tsx, src/wallet-service-worker.ts) with overlapping changes across dependencies and wallet/service worker logic.
PR #316 — Updates service worker activation and reload behavior, directly related to the skip-waiting and client claim refactoring in this PR.
PR #309 — Bumps the same @arkade-os/sdk and @arkade-os/boltz-swap dependency versions in package.json.

Suggested reviewers

bordalix
louisinger

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Handle ServiceWorker lifecycle' accurately reflects the main changes in the PR, which focus on managing Service Worker lifecycle through SKIP_WAITING, preventing wallet status pings when locked, and updating dependencies.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch handle-sw-lifecycle

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cloudflare-workers-and-pages · 2026-03-04T05:31:06Z

Deploying wallet-mutinynet with Cloudflare Pages

Latest commit:	`1bd3a4a`
Status:	✅ Deploy successful!
Preview URL:	https://5d83d6a3.arkade-wallet.pages.dev
Branch Preview URL:	https://handle-sw-lifecycle.arkade-wallet.pages.dev

View logs

pietro909 · 2026-03-04T09:25:28Z

@CodeRabbit review - we're closing the circle with what was implemented her arkade-os/ts-sdk#329 to ensure the Service Worker never gets stuck across releases.

coderabbitai · 2026-03-04T09:25:45Z

@pietro909 Sure! I'll kick off a review of the PR now. Thanks for the context on the ServiceWorker lifecycle fix — I'll keep in mind that this builds on the work in arkade-os/ts-sdk#329 to prevent the Service Worker from getting stuck across releases.

🧠 Learnings used

Learnt from: bordalix
Repo: arkade-os/wallet PR: 114
File: src/lib/asp.ts:0-0
Timestamp: 2025-06-30T18:33:29.839Z
Learning: In src/lib/asp.ts, only the collaborativeExit function should accept both IWallet and ServiceWorkerWallet types. Other wallet functions (getBalance, getTxHistory, getReceivingAddresses, redeemNotes, sendOnChain, settleVtxos) should maintain their original IWallet-only signatures and not be updated for consistency.

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

🧹 Nitpick comments (1)

src/wallet-service-worker.ts (1)
14-17: Wrap skipWaiting() in event.waitUntil() to extend worker lifetime during activation.

The ExtendableMessageEvent supports event.waitUntil(promise) to keep the service worker alive while async work completes. Since skipWaiting() returns a promise that resolves once activation is attempted, wrapping it ensures the browser doesn't terminate the worker mid-transition.
Suggested patch
 self.addEventListener('message', (event: ExtendableMessageEvent) => {
   if (event.data?.type === 'SKIP_WAITING') {
-    self.skipWaiting()
+    event.waitUntil(self.skipWaiting())
   }
 })
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/wallet-service-worker.ts` around lines 14 - 17, The message handler that
listens via self.addEventListener and checks for event.data?.type ===
'SKIP_WAITING' should call skipWaiting() inside event.waitUntil(...) so the
service worker stays alive until activation completes; update the handler for
ExtendableMessageEvent to call event.waitUntil(self.skipWaiting()) instead of
calling self.skipWaiting() directly.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/wallet-service-worker.ts`:
- Around line 14-17: The message handler that listens via self.addEventListener
and checks for event.data?.type === 'SKIP_WAITING' should call skipWaiting()
inside event.waitUntil(...) so the service worker stays alive until activation
completes; update the handler for ExtendableMessageEvent to call
event.waitUntil(self.skipWaiting()) instead of calling self.skipWaiting()
directly.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 841272ff-a047-4229-9c06-a65df9a8201a

📥 Commits

Reviewing files that changed from the base of the PR and between 8b158fe and f10bb1f.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (5)

.gitignore
package.json
public/wallet-service-worker.mjs
src/providers/wallet.tsx
src/wallet-service-worker.ts

pietro909 added 3 commits March 4, 2026 06:25

Ignore md helpers

e954ef1

Stop pinging wallet when locked

3f0a3de

Allow the page to force activation of a newly installed worker.

942a621

pietro909 changed the title ~~Handle sw lifecycle~~ Handle ServiceWorker lifecycle Mar 4, 2026

pietro909 marked this pull request as ready for review March 4, 2026 09:21

Upgrade sdk and boltz-swap

f10bb1f

pietro909 requested a review from bordalix March 4, 2026 09:25

coderabbitai Bot reviewed Mar 4, 2026

View reviewed changes

Use event.waitUntil

1bd3a4a

pietro909 merged commit b27c132 into next Mar 4, 2026
3 checks passed

pietro909 deleted the handle-sw-lifecycle branch March 4, 2026 11:32

coderabbitai Bot mentioned this pull request Mar 6, 2026

Upgrade SDK, boltz, use 30s ServiceWorker timeout #371

Merged

This was referenced Mar 13, 2026

fix improper service worker initialization after update #422

Closed

Fix service worker update #431

Merged

coderabbitai Bot mentioned this pull request Mar 27, 2026

fix: unregister stuck service worker to recover from loading deadlock #487

Merged

3 tasks

coderabbitai Bot mentioned this pull request May 12, 2026

Fix dead service worker #613

Merged

Navigation Menu

Repository navigation

Handle ServiceWorker lifecycle - #357

Handle ServiceWorker lifecycle#357
pietro909 merged 5 commits into
nextfrom
handle-sw-lifecycle

pietro909 commented Mar 4, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

cloudflare-workers-and-pages Bot commented Mar 4, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Mar 4, 2026 •

edited

Loading

Review skipped

Uh oh!

cloudflare-workers-and-pages Bot commented Mar 4, 2026 •

edited

Loading

Uh oh!

pietro909 commented Mar 4, 2026

Uh oh!

coderabbitai Bot commented Mar 4, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

pietro909 commented Mar 4, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Release Notes

Uh oh!

cloudflare-workers-and-pages Bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying wallet-bitcoin with Cloudflare Pages

Uh oh!

coderabbitai Bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Uh oh!

cloudflare-workers-and-pages Bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying wallet-mutinynet with Cloudflare Pages

Uh oh!

pietro909 commented Mar 4, 2026

Uh oh!

coderabbitai Bot commented Mar 4, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

pietro909 commented Mar 4, 2026 •

edited by coderabbitai Bot

Loading

cloudflare-workers-and-pages Bot commented Mar 4, 2026 •

edited

Loading

coderabbitai Bot commented Mar 4, 2026 •

edited

Loading

cloudflare-workers-and-pages Bot commented Mar 4, 2026 •

edited

Loading