Repository navigation
Hotfix positioning - #333
Merged
Merged
Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughRemoved Button's Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant AmountScreen as Amount.tsx
participant Keyboard
participant FaucetFlow as Faucet/Receive UI
User->>AmountScreen: open / interact
AmountScreen->>AmountScreen: check showKeys
alt showKeys == true
AmountScreen->>Keyboard: render Keyboard (early return)
Keyboard-->>User: collect input / back
else showKeys == false
AmountScreen->>FaucetFlow: proceed with faucet / invoice / QR flow
FaucetFlow-->>User: render receive UI or QR
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying wallet-bitcoin with
|
| Latest commit: |
7ff9d44
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://446b7d32.wallet-bitcoin.pages.dev |
| Branch Preview URL: | https://hotfix-positioning.wallet-bitcoin.pages.dev |
Deploying wallet-mutinynet with
|
| Latest commit: |
7ff9d44
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f01a2019.arkade-wallet.pages.dev |
| Branch Preview URL: | https://hotfix-positioning.arkade-wallet.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/screens/Wallet/Receive/Amount.tsx (1)
132-134: Remove duplicatedshowKeysbranching to eliminate dead code.Line 132 introduces an early return for
showKeys, so the laterif (showKeys)block at Lines 159-161 is unreachable. Keep a single branch to avoid stale logic paths.♻️ Proposed cleanup
if (showKeys) { return <Keyboard back={() => setShowKeys(false)} hideBalance onSats={handleChange} value={satoshis} /> } @@ - if (showKeys) { - return <Keyboard back={() => setShowKeys(false)} hideBalance onSats={handleChange} value={satoshis} /> - } - return (🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/screens/Wallet/Receive/Amount.tsx` around lines 132 - 134, There are two separate `if (showKeys)` branches in the Receive Amount component causing dead code; keep a single branch by removing the later unreachable block. Locate the early return that renders <Keyboard back={() => setShowKeys(false)} hideBalance onSats={handleChange} value={satoshis} /> and delete the subsequent duplicate `if (showKeys)` block (the later rendering of Keyboard/related logic) so the component only uses the initial `showKeys` branch and no stale logic remains.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/screens/Wallet/Receive/Amount.tsx`:
- Around line 132-134: There are two separate `if (showKeys)` branches in the
Receive Amount component causing dead code; keep a single branch by removing the
later unreachable block. Locate the early return that renders <Keyboard back={()
=> setShowKeys(false)} hideBalance onSats={handleChange} value={satoshis} /> and
delete the subsequent duplicate `if (showKeys)` block (the later rendering of
Keyboard/related logic) so the component only uses the initial `showKeys` branch
and no stale logic remains.
This was referenced Mar 4, 2026
5 tasks
Merged
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes positioning errors introduced by page animations.
Summary by CodeRabbit
Bug Fixes
Style
Refactor