Skip to content

fix tab icons in ios pwa - #297

Merged
bordalix merged 1 commit into
masterfrom
ios_pwa_icons
Jan 6, 2026
Merged

bordalix merged 1 commit into
masterfrom
ios_pwa_icons

Conversation

@bordalix

@bordalix bordalix commented Jan 6, 2026 •

Copy link
Copy Markdown
Collaborator

@tiero can you please test it on your phone?

Summary by CodeRabbit

  • Style
    • Updated tab button padding and background styling for a refined appearance
    • Enhanced focus behavior for improved keyboard navigation experience within tab buttons

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Jan 6, 2026 •

Copy link
Copy Markdown
Contributor

Walkthrough

This pull request modifies CSS styling for ion-tab-bar button components. It removes custom properties (--padding-end, --padding-start, --background-focused) and the background-color variable declaration from ion-tab-button, while introducing a new focus override rule that sets transparent background-color for focusable child elements.

Changes

Cohort / File(s) Summary
Tab Button Styling
src/ionic.css
Removed CSS custom properties (--padding-end, --padding-start, --background-focused) and background-color declaration from ion-tab-button. Added new focus behavior rule for focusable children within tab buttons to override background-color with transparent on focus state.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix tab icons in ios pwa' is partially related to the changeset, referring to tab styling changes, but does not clearly indicate the specific CSS modifications (custom properties removal and focus behavior changes) being made.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying wallet-bitcoin with  Cloudflare Pages  Cloudflare Pages

Latest commit: 50d9dcc
Status: ✅  Deploy successful!
Preview URL: https://642c8af7.wallet-bitcoin.pages.dev
Branch Preview URL: https://ios-pwa-icons.wallet-bitcoin.pages.dev

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying wallet-mutinynet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 50d9dcc
Status: ✅  Deploy successful!
Preview URL: https://2088b6d8.arkade-wallet.pages.dev
Branch Preview URL: https://ios-pwa-icons.arkade-wallet.pages.dev

View logs

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI Agents
In @src/ionic.css:
- Around line 153-155: The new CSS rule making .focusable:focus
background-color: transparent removes the visible focus indicator for tab
buttons; restore an accessible focus style by removing that override or by
adding an explicit visible focus indicator (e.g., outline, box-shadow or border)
for the .focusable:focus selector so keyboard focus is visible across iOS PWA,
Android PWA and desktop browsers; update the .focusable:focus rule in
src/ionic.css (the .focusable class and its :focus state) to ensure a clear,
high-contrast focus ring on tab buttons while preserving any platform-specific
defaults if needed.
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 25f16fd and 50d9dcc.

📒 Files selected for processing (1)
  • src/ionic.css
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: test
  • GitHub Check: Cloudflare Pages: wallet-mutinynet

Comment thread src/ionic.css Resolved
@tiero

tiero commented Jan 6, 2026

Copy link
Copy Markdown
Member

tack

Less code guess better this

image

@bordalix
bordalix merged commit 7a4b0a8 into master Jan 6, 2026
5 checks passed
@bordalix
bordalix deleted the ios_pwa_icons branch January 6, 2026 19:00
bordalix added a commit that referenced this pull request Jan 7, 2026
@coderabbitai coderabbitai Bot mentioned this pull request Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants