Repository navigation
fix tab icons in ios pwa - #297
Merged
Merged
Conversation
Contributor
WalkthroughThis pull request modifies CSS styling for ion-tab-bar button components. It removes custom properties (--padding-end, --padding-start, --background-focused) and the background-color variable declaration from ion-tab-button, while introducing a new focus override rule that sets transparent background-color for focusable child elements. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying wallet-bitcoin with
|
| Latest commit: |
50d9dcc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://642c8af7.wallet-bitcoin.pages.dev |
| Branch Preview URL: | https://ios-pwa-icons.wallet-bitcoin.pages.dev |
Deploying wallet-mutinynet with
|
| Latest commit: |
50d9dcc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2088b6d8.arkade-wallet.pages.dev |
| Branch Preview URL: | https://ios-pwa-icons.arkade-wallet.pages.dev |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI Agents
In @src/ionic.css:
- Around line 153-155: The new CSS rule making .focusable:focus
background-color: transparent removes the visible focus indicator for tab
buttons; restore an accessible focus style by removing that override or by
adding an explicit visible focus indicator (e.g., outline, box-shadow or border)
for the .focusable:focus selector so keyboard focus is visible across iOS PWA,
Android PWA and desktop browsers; update the .focusable:focus rule in
src/ionic.css (the .focusable class and its :focus state) to ensure a clear,
high-contrast focus ring on tab buttons while preserving any platform-specific
defaults if needed.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/ionic.css
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: test
- GitHub Check: Cloudflare Pages: wallet-mutinynet
Member
This was referenced Jan 7, 2026
bordalix
added a commit
that referenced
this pull request
Jan 7, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

@tiero can you please test it on your phone?
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.