[pietro909]

Summary by CodeRabbit

• Chores
  • Updated underlying components to newer versions. No user-facing features, behavior changes, or fixes are included in this release; the available functionality remains unchanged. These updates do not alter the experience of using the product.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 5c1b06c3-e815-48c8-951c-9919af9cc6ae

📥 Commits

Reviewing files that changed from the base of the PR and between ad6235e and cd870f1.

⛔ Files ignored due to path filters: 1

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing: 1

• package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The pull request updates the @arkade-os/sdk and @arkade-os/swap dependency versions in package.json. The @arkade-os/solver-discovery version stays unchanged.

Changes

Dependency Version Update

Layer / File(s)	Summary
Update SDK and swap versions package.json	The SDK version changes to 0.5.0-rc.24, and the swap version changes to 0.1.0-rc.27. The solver-discovery version remains 0.3.0.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: bordalix

Merge Risk: ⚪ Minimal · up to cd870

The upgraded dependency versions are consistent between the manifest and lockfile, including swap’s SDK requirement. No actionable merge risk is identified.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely identifies the two dependency upgrades described in the pull request.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cloudflare-workers-and-pages]

Deploying wallet-bitcoin with    Cloudflare Pages

Latest commit:	cd870f1
Status:	✅  Deploy successful!
Preview URL:	https://894fe1f2.wallet-bitcoin.pages.dev
Branch Preview URL:	https://upgrade-sdk-0-5-0-rc24.wallet-bitcoin.pages.dev

View logs

[cloudflare-workers-and-pages]

Deploying wallet-mutinynet with    Cloudflare Pages

Latest commit:	cd870f1
Status:	✅  Deploy successful!
Preview URL:	https://acf031f9.arkade-wallet.pages.dev
Branch Preview URL:	https://upgrade-sdk-0-5-0-rc24.arkade-wallet.pages.dev

View logs

[arkana-ai-bot]

Dependency bump: @arkade-os/sdk rc.23→rc.24, @arkade-os/swap rc.26→rc.27

Scope: package.json (4 lines changed) + pnpm-lock.yaml (generated, excluded from detailed review). No source changes.

---

What landed in rc.24 / rc.27

I cross-referenced the ts-sdk CHANGELOG.md (Unreleased section, commit 1f2456c) and the local clone at packages/{sdk,swap}. The two increments that matter for this wallet:

rc.27 (swap) — protocol-relevant fixes:

1. Dust-stuffed lockup fix (@arkade-os/swap). Anyone paying dust to a lockup address previously caused pushClaim / pushRefundWithoutReceiver to take every output, exceeding maxTxWeight and leaving funds permanently stuck. rc.27 caps lockup spends at MAX_LOCKUP_SPEND_INPUTS (16), largest-first, and the claim/refund manager re-runs on subsequent passes for any remainder. This is a real fund-recovery fix.

2. Registry-outage / pinned card logic (@arkade-os/swap). A registry outage previously replaced the cached markets with pinned cards only. Now only a live registry answer updates the cache; a registry-unreachable state surfaces as source: "local" on SnapshotRef and retries after one minute rather than sitting on the full TTL. This is the SnapshotRef.source breaking-change entry in the changelog.

3. Partial-refund mark fix. arkadeRefunder no longer marks a partially-succeeded refund as failed.

rc.24 (SDK): No individual RC changelog entry exists; the unreleased section covers the full 0.5.0 development line. The SDK bump tracks the swap package dependency update inside @arkade-os/swap.

---

Breaking-change audit against wallet source

The unreleased CHANGELOG lists several breaking changes. I searched src/ (excluding node_modules) for every affected symbol:

Breaking change	Symbol(s) searched	Found in wallet src?
receivePkScriptFor removed from @arkade-os/swap/protocol	receivePkScriptFor	No
refundIfUnresolved / claimReceiveLockup / awaitLockupFunding / RefundOutcome removed from @arkade-os/swap/protocol	all four	No
RFQ_AD_KIND removed from @arkade-os/swap/nostr	RFQ_AD_KIND	No — wallet uses RFQ_DIRECTED_KIND (still exported)
SnapshotRef.source gains "local" (exhaustive switch risk)	SnapshotRef	No switch on this field found
IContractManager.dispose() returns Promise<void>	IContractManager	No direct usage in src/
ArkadeCashUnclaimedReason drops "swept"	ArkadeCashUnclaimedReason, "swept"	Not matched as a reason enum; wallet's "nothing-swept" is a different constant
buildAndSubmitOffchainTx acquires wallet lock	buildAndSubmitOffchainTx	Not used in src/

All symbols the wallet actually imports from these packages (BTC_ASSET_ID, getAssetSwaps, findMarket, makeCachedFeedFetch, QUOTE_OPTIONS, validatePlan, lightningSendRequest, discoverMarkets, watchMarkets, RFQ_DIRECTED_KIND, nostrRfqTransport) remain exported in rc.24/rc.27 — confirmed against the ts-sdk source tree.

---

CI

All 7 checks green on cd870f1: Cloudflare Pages (mutinynet + bitcoin), unit tests, and E2E (core + assets-send, Chrome + Mobile Chrome).

---

Lockfile

Integrity hashes for both packages changed as expected. pnpm-lock.yaml shows @arkade-os/swap@0.1.0-rc.27 still resolves @arkade-os/sdk@0.5.0-rc.24 as its own dependency (consistent), and @arkade-os/solver-discovery pins remain at 0.3.0 (unchanged).

---

No issues found. The bump is safe to merge; rc.27 in particular closes a real fund-recovery risk.