Repository navigation
removes dead code - #1024
removes dead code#1024
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (48)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying wallet-bitcoin with
|
| Latest commit: |
f05bd48
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7b6a5f0d.wallet-bitcoin.pages.dev |
| Branch Preview URL: | https://equinox-cleanup.wallet-bitcoin.pages.dev |
Deploying wallet-mutinynet with
|
| Latest commit: |
f05bd48
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5f4d36c5.arkade-wallet.pages.dev |
| Branch Preview URL: | https://equinox-cleanup.arkade-wallet.pages.dev |
arkana-ai-bot
left a comment
There was a problem hiding this comment.
Arkana review — PR #1024 "removes dead code"
Scope: Pure UI dead-code removal. No VTXO handling, signing, forfeit paths, round lifecycle, or unilateral-exit code was touched. No protocol-critical review trigger applies.
What was verified
Import graph — no dangling references.
All 44 deleted src/components/ui/ wrappers (accordion, avatar, calendar, card, carousel, chart, combobox, command, dialog, menubar, sidebar, etc.) have zero remaining import references in src/. The grep across *.ts / *.tsx returned no hits for any of the deleted paths.
Removed npm dependencies — confirmed unused in source.
embla-carousel-react, input-otp, react-day-picker, react-resizable-panels, and recharts have no remaining import statements anywhere under src/. Their transitive graph (@reduxjs/toolkit, D3 type packages, @standard-schema/*, @tabby_ai/hijri-converter, @types/use-sync-external-store) is cleaned from pnpm-lock.yaml correctly.
Sonner / toast continuity.
src/components/ui/sonner.tsx (the wrapper) was deleted; the sonner package itself remains. src/components/Toast.tsx imports Toaster and toast directly from sonner and is the sole toast provider. assetSwaps.tsx, swap.test.tsx, and the other consumers all route through Toast.tsx. No regression.
Custom components unaffected.
The project's own implementations — src/components/Input.tsx, Select.tsx, Table.tsx, Toggle.tsx, Empty.tsx, Spinner.tsx, etc. — are distinct from the deleted src/components/ui/ wrappers and remain intact.
Cross-repo impact.
These were internal UI primitives, not exported from any package. No consumers found in the other SDK clones (ts-sdk, go-sdk, rust-sdk, dotnet-sdk).
Findings
None. The deletion is complete and consistent: every removed file has no surviving import, and every removed dependency has no surviving usage.
Notes (non-blocking)
- Danger / PR size warning: The 5 293-line count is almost entirely
pnpm-lock.yamlchurn (correctly excluded from the attention plan). The meaningful deletion is the 44 component files. node_moduleson the VPS still contains the old packages untilpnpm installis run post-merge — expected, not a code issue.
LGTM.
Summary by CodeRabbit