Skip to content

removes dead code - #1024

Merged
tiero merged 1 commit into
masterfrom
equinox_cleanup
Sep 25, 2026
Merged

tiero merged 1 commit into
masterfrom
equinox_cleanup

Conversation

@bordalix

@bordalix bordalix commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Removed a broad set of unused interface components, including calendars, charts, menus, dialogs, navigation, and form controls.
    • Removed the associated carousel, charting, date-picker, OTP input, resizable-panel, and graphing dependencies.
    • Some reusable interface elements are no longer available.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 47309b61-e6e3-4fc8-8829-e450844eda4a

📥 Commits

Reviewing files that changed from the base of the PR and between 17ecea2 and f05bd48.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (48)
  • package.json
  • src/components/ui/accordion.tsx
  • src/components/ui/alert.tsx
  • src/components/ui/aspect-ratio.tsx
  • src/components/ui/avatar.tsx
  • src/components/ui/breadcrumb.tsx
  • src/components/ui/button-group.tsx
  • src/components/ui/calendar.tsx
  • src/components/ui/card.tsx
  • src/components/ui/carousel.tsx
  • src/components/ui/chart.tsx
  • src/components/ui/collapsible.tsx
  • src/components/ui/combobox.tsx
  • src/components/ui/command.tsx
  • src/components/ui/context-menu.tsx
  • src/components/ui/dialog.tsx
  • src/components/ui/direction.tsx
  • src/components/ui/empty.tsx
  • src/components/ui/field.tsx
  • src/components/ui/hover-card.tsx
  • src/components/ui/input-group.tsx
  • src/components/ui/input-otp.tsx
  • src/components/ui/input.tsx
  • src/components/ui/item.tsx
  • src/components/ui/kbd.tsx
  • src/components/ui/label.tsx
  • src/components/ui/menubar.tsx
  • src/components/ui/native-select.tsx
  • src/components/ui/navigation-menu.tsx
  • src/components/ui/pagination.tsx
  • src/components/ui/popover.tsx
  • src/components/ui/progress.tsx
  • src/components/ui/resizable.tsx
  • src/components/ui/scroll-area.tsx
  • src/components/ui/select.tsx
  • src/components/ui/separator.tsx
  • src/components/ui/sheet.tsx
  • src/components/ui/sidebar.tsx
  • src/components/ui/skeleton.tsx
  • src/components/ui/slider.tsx
  • src/components/ui/sonner.tsx
  • src/components/ui/spinner.tsx
  • src/components/ui/table.tsx
  • src/components/ui/tabs.tsx
  • src/components/ui/textarea.tsx
  • src/components/ui/toggle-group.tsx
  • src/components/ui/toggle.tsx
  • src/components/ui/tooltip.tsx
 ____________________________________________________________
< Your code has 99 problems and bug fixes ain't none of 'em. >
 ------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying wallet-bitcoin with  Cloudflare Pages  Cloudflare Pages

Latest commit: f05bd48
Status: ✅  Deploy successful!
Preview URL: https://7b6a5f0d.wallet-bitcoin.pages.dev
Branch Preview URL: https://equinox-cleanup.wallet-bitcoin.pages.dev

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying wallet-mutinynet with  Cloudflare Pages  Cloudflare Pages

Latest commit: f05bd48
Status: ✅  Deploy successful!
Preview URL: https://5f4d36c5.arkade-wallet.pages.dev
Branch Preview URL: https://equinox-cleanup.arkade-wallet.pages.dev

View logs

@tiero
tiero merged commit c2c9516 into master Sep 25, 2026
7 of 8 checks passed

@arkana-ai-bot arkana-ai-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arkana review — PR #1024 "removes dead code"

Scope: Pure UI dead-code removal. No VTXO handling, signing, forfeit paths, round lifecycle, or unilateral-exit code was touched. No protocol-critical review trigger applies.


What was verified

Import graph — no dangling references.
All 44 deleted src/components/ui/ wrappers (accordion, avatar, calendar, card, carousel, chart, combobox, command, dialog, menubar, sidebar, etc.) have zero remaining import references in src/. The grep across *.ts / *.tsx returned no hits for any of the deleted paths.

Removed npm dependencies — confirmed unused in source.
embla-carousel-react, input-otp, react-day-picker, react-resizable-panels, and recharts have no remaining import statements anywhere under src/. Their transitive graph (@reduxjs/toolkit, D3 type packages, @standard-schema/*, @tabby_ai/hijri-converter, @types/use-sync-external-store) is cleaned from pnpm-lock.yaml correctly.

Sonner / toast continuity.
src/components/ui/sonner.tsx (the wrapper) was deleted; the sonner package itself remains. src/components/Toast.tsx imports Toaster and toast directly from sonner and is the sole toast provider. assetSwaps.tsx, swap.test.tsx, and the other consumers all route through Toast.tsx. No regression.

Custom components unaffected.
The project's own implementations — src/components/Input.tsx, Select.tsx, Table.tsx, Toggle.tsx, Empty.tsx, Spinner.tsx, etc. — are distinct from the deleted src/components/ui/ wrappers and remain intact.

Cross-repo impact.
These were internal UI primitives, not exported from any package. No consumers found in the other SDK clones (ts-sdk, go-sdk, rust-sdk, dotnet-sdk).


Findings

None. The deletion is complete and consistent: every removed file has no surviving import, and every removed dependency has no surviving usage.


Notes (non-blocking)

  • Danger / PR size warning: The 5 293-line count is almost entirely pnpm-lock.yaml churn (correctly excluded from the attention plan). The meaningful deletion is the 44 component files.
  • node_modules on the VPS still contains the old packages until pnpm install is run post-merge — expected, not a code issue.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants