fix: add missing Mod case to the typed-AST JSON emitter - #227
Merged
Conversation
`act type` crashed with `todo: json ast for: Mod ...` after successfully typechecking any spec that uses the % operator: the ToJSON instance for typed expressions covered every constructor except Mod, falling through to the error catch-all. Add the Mod case (mirroring Div) and delete the catch-all, which the exhaustiveness checker now proves dead (Mod was the only missing constructor; keeping it trips -Werror=overlapping-patterns). Regression test: a minimal %-using spec under tests/typing/pass, which exercises `act type | jq .` via the .type.pass make target. The existing %-specs under tests/hevm never hit this path.
Collaborator
|
Thank you for the fix. I have added the missing test output. Once the CI passes we will accept and merge. |
anjapetkovic
approved these changes
Jul 30, 2026
anjapetkovic
left a comment
anjapetkovic
left a comment
Collaborator
There was a problem hiding this comment.
Looks good and the checks now pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
act typecrashed withtodo: json ast for: Mod ...after successfully typechecking any spec that uses the % operator: the ToJSON instance for typed expressions covered every constructor except Mod, falling through to the error catch-all.Add the Mod case (mirroring Div) and delete the catch-all, which the exhaustiveness checker now proves dead (Mod was the only missing constructor; keeping it trips -Werror=overlapping-patterns).
Regression test: a minimal %-using spec under tests/typing/pass, which exercises
act type | jq .via the .type.pass make target. The existing %-specs under tests/hevm never hit this path.