Fix focal points between separated salient regions - #9
Merged
Conversation
Greptile SummaryThe PR changes focal-point calculation to select the 8-connected salient region with the greatest integrated saliency before calculating its weighted centroid.
Confidence Score: 5/5The PR appears safe to merge; no outstanding correctness, security, or repository-rule issues remain. The diagonal-connectivity regression fully addresses the resolved previous finding, and the changes since the previous review introduce no actionable new issue. Important Files Changed
Reviews (3): Last reviewed commit: "test: cover diagonal saliency connectivi..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This prevents two separated subjects from averaging to a focal point in empty space between them.
Before and after
The supplied example changes from gravity=(0.4705, 0.4784) to gravity=(0.0770, 0.4788), selecting the stronger left-dog region.
Validation