Skip to content

Move import of CommonDigest.h to allow building as framework - #53

Merged
jasperblues merged 2 commits into
appsquickly:masterfrom
iosdevzone:master
Sep 20, 2015
Merged

jasperblues merged 2 commits into
appsquickly:masterfrom
iosdevzone:master

Conversation

@iosdevzone

Copy link
Copy Markdown
Contributor

I wanted to use XcodeEditor from Swift so I was using use_frameworks! in my Podfile. This causes a problem compiling XCKeyBuilder.h. For reasons best known to them, Apple do not include a module.map for CommonCrypto and this causes the error below.

Include of non-modular header inside framework module 'XcodeEditor.XCKeyBuilder'

This pull request works around the error by moving the import into the .m file and defining a macro for the digest length.

jasperblues added a commit that referenced this pull request Sep 20, 2015
Move import of CommonDigest.h to allow building as framework
@jasperblues
jasperblues merged commit 9f1a7e6 into appsquickly:master Sep 20, 2015
@jasperblues

Copy link
Copy Markdown
Member

Thanks @iosdevzone ! If you like I can publish a new CocoaPods version? Meanwhile you can use with:

pod 'XcodeEditor', :head

@iosdevzone

Copy link
Copy Markdown
Contributor Author

You're welcome.

Don't do that on my account. I'm working on my fork as a development pod at the moment because I suspect I may need to make more changes. I'll issue pull requests when it makes sense.

Thanks for writing this. Looks like it is going to be very useful for me. I'll drop you a line letting you know what I'm up to once I know it is going to work ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants