Add support for Windows - #148
Merged
Merged
Conversation
Contributor
|
Actually, could you bring over the changes from #142 into this PR? I'd like the PR that enables the CI to also verify it'll be green. I'll close mine afterwards. |
CoreFoundation isn't API on Windows, so compile it out in that case. All tests pass with these changes.
czechboy0
approved these changes
Apr 1, 2025
czechboy0
left a comment
czechboy0
left a comment
Contributor
There was a problem hiding this comment.
Thank you, @jakepetroules 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoreFoundation isn't API on Windows, so compile it out in that case. All tests pass with these changes.