Skip to content

Fixed typo signalStrengh #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KazuCocoa merged 6 commits into from
Mar 7, 2019
Merged

Fixed typo signalStrengh #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f0f885a
Fixed typo signalStrengh
khanhdodang Mar 5, 2019
b75cf33
Update signalStrengh
khanhdodang Mar 5, 2019
f044bea
Added backwards compatible
khanhdodang Mar 6, 2019
5064421
Fixed "Indent the right brace the same as the first position after th…
khanhdodang Mar 6, 2019
3a50b5c
Fixed long line
khanhdodang Mar 6, 2019
6451baf
Fixed unittest
khanhdodang Mar 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/appium_lib_core/android/device/emulator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,8 @@ def gsm_call(phone_number:, action:)
def gsm_signal(signal_strength)
raise "#{signal_strength} should be member of #{GSM_SIGNALS} " if GSM_SIGNALS[signal_strength.to_sym].nil?

execute(:gsm_signal, {}, { signalStrengh: GSM_SIGNALS[signal_strength] })
execute(:gsm_signal, {}, { signalStrength: GSM_SIGNALS[signal_strength],
signalStrengh: GSM_SIGNALS[signal_strength] })
end
end

Expand Down
3 changes: 2 additions & 1 deletion test/unit/android/device/mjsonwp/commands_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,8 @@ def test_gsm_call

def test_gsm_signal
stub_request(:post, "#{SESSION}/appium/device/gsm_signal")
.with(body: { signalStrengh: ::Appium::Core::Android::Device::Emulator::GSM_SIGNALS[:good] }.to_json)
.with(body: { signalStrength: ::Appium::Core::Android::Device::Emulator::GSM_SIGNALS[:good],
signalStrengh: ::Appium::Core::Android::Device::Emulator::GSM_SIGNALS[:good] }.to_json)
.to_return(headers: HEADER, status: 200, body: { value: '' }.to_json)

@driver.gsm_signal :good
Expand Down
3 changes: 2 additions & 1 deletion test/unit/android/device/w3c/commands_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,8 @@ def test_gsm_call

def test_gsm_signal
stub_request(:post, "#{SESSION}/appium/device/gsm_signal")
.with(body: { signalStrengh: ::Appium::Core::Android::Device::Emulator::GSM_SIGNALS[:good] }.to_json)
.with(body: { signalStrength: ::Appium::Core::Android::Device::Emulator::GSM_SIGNALS[:good],
signalStrengh: ::Appium::Core::Android::Device::Emulator::GSM_SIGNALS[:good] }.to_json)
.to_return(headers: HEADER, status: 200, body: { value: '' }.to_json)

@driver.gsm_signal :good
Expand Down
2 changes: 1 addition & 1 deletion test/unit/script/test_routes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ const METHOD_MAP = {
POST: {command: 'gsmCall', payloadParams: {required: ['phoneNumber', 'action']}}
},
'/wd/hub/session/:sessionId/appium/device/gsm_signal': {
POST: {command: 'gsmSignal', payloadParams: {required: ['signalStrengh']}}
POST: {command: 'gsmSignal', payloadParams: {required: ['signalStrength']}}
},
'/wd/hub/session/:sessionId/appium/device/gsm_voice': {
POST: {command: 'gsmVoice', payloadParams: {required: ['state']}}
Expand Down