This repository was archived by the owner on Oct 25, 2023. It is now read-only.
feat: add calling chrome devtools endpoint for chromium - #405
Merged
Conversation
| // chromium devtools | ||
| // https://chromium.googlesource.com/chromium/src/+/master/chrome/test/chromedriver/server/http_handler.cc | ||
| '/session/:sessionId/goog/cdp/execute': { | ||
| POST: {} |
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
and the command name
|
|
||
| // chromium devtools | ||
| // https://chromium.googlesource.com/chromium/src/+/master/chrome/test/chromedriver/server/http_handler.cc | ||
| '/session/:sessionId/goog/cdp/execute': { |
Contributor
There was a problem hiding this comment.
goog is a vendor prefix in such case. It makes sense to replace it with a pattern matcher, like :vendor
mykola-mokhnach
approved these changes
Apr 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome browser support
/session/:sessionId/goog/cdp/executeendpoint.Selenium bindings, afaik Java, Python and Ruby, have the endpoint.
We also can support it for chromebrowser. Below is an example.
https://chromedevtools.github.io/devtools-protocol
Without this change, Appium returns below error.