feat: add github actions for release - #117
Merged
Merged
Conversation
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
Contributor
already done |
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
Contributor
Author
|
@membphis PTAL I think it works for now since I test it in my own repo and it works fine (see workflow in my repo) Also plz make sure the token name in secrets is |
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
Contributor
Author
|
CI could be fixed with #120 |
Contributor
Contributor
Author
Thanks a lot for the help! CI has passed and I think it could be reviewed~ |
membphis
approved these changes
Feb 8, 2021
Contributor
|
we can make a try when we release a new version next time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Signed-off-by: yiyiyimu wosoyoung@gmail.com
Mentioned in #116
I think we could add a Github Actions to automize the version release. It could also work for other repos of api7 that need to upload to luarocks.
The process would be like, whenever we push a new tag, it would upload the new release on github and also upload rockspec to luarocks.
One thing to discuss is that, do we need to bind the release action to PR, say when we have a release PR tagged with "Release", when it got merged, the action would be triggered to create a tag, and do the rest.
It would be more convenient, but we need an extra PR when changing release larger change, say from 1.4.3 to 1.5. Ref: https://github.com/anothrNick/github-tag-action
TODO