Skip to content

feat: add github actions for release - #117

Merged
membphis merged 5 commits into
api7:masterfrom
Yiyiyimu:gh-release
Feb 11, 2021
Merged

feat: add github actions for release#117
membphis merged 5 commits into
api7:masterfrom
Yiyiyimu:gh-release

Conversation

@Yiyiyimu

@Yiyiyimu Yiyiyimu commented Feb 2, 2021

Copy link
Copy Markdown
Contributor

Signed-off-by: yiyiyimu wosoyoung@gmail.com

Mentioned in #116

I think we could add a Github Actions to automize the version release. It could also work for other repos of api7 that need to upload to luarocks.

The process would be like, whenever we push a new tag, it would upload the new release on github and also upload rockspec to luarocks.

One thing to discuss is that, do we need to bind the release action to PR, say when we have a release PR tagged with "Release", when it got merged, the action would be triggered to create a tag, and do the rest.
It would be more convenient, but we need an extra PR when changing release larger change, say from 1.4.3 to 1.5. Ref: https://github.com/anothrNick/github-tag-action

TODO

  • test on personal repo to make sure it works
  • ask @membphis for upload luarocks token

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
@membphis

membphis commented Feb 3, 2021

Copy link
Copy Markdown
Contributor

already done

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
@Yiyiyimu

Yiyiyimu commented Feb 7, 2021

Copy link
Copy Markdown
Contributor Author

@membphis PTAL

I think it works for now since I test it in my own repo and it works fine (see workflow in my repo)

Also plz make sure the token name in secrets is LUAROCKS_TOKEN

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
@Yiyiyimu

Yiyiyimu commented Feb 7, 2021

Copy link
Copy Markdown
Contributor Author

CI could be fixed with #120

@membphis

membphis commented Feb 7, 2021

Copy link
Copy Markdown
Contributor

Also plz make sure the token name in secrets is LUAROCKS_TOKEN

you can take a look

image

@Yiyiyimu

Yiyiyimu commented Feb 7, 2021

Copy link
Copy Markdown
Contributor Author

you can take a look

Thanks a lot for the help!

CI has passed and I think it could be reviewed~

@membphis
membphis merged commit 55e57a8 into api7:master Feb 11, 2021
@membphis

Copy link
Copy Markdown
Contributor

we can make a try when we release a new version next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants