ci(codeql): bump init and analyze together to v4.37.3 - #73
Merged
Merged
Conversation
Dependabot #65 bumped only `codeql-action/init`, which would have left `analyze` on v3. The CodeQL Action requires both sub-actions to come from the same release, so a split would break the `analyze` job — one of the checks gating merges to main. `v4.37.3` and `v4` both resolve to commit e4fba868, and analyze/action.yml is present there, so a single pinned SHA covers both. The v4 line raises the minimum CodeQL bundle to 2.19.4 and deprecates the undocumented CODEQL_ACTION_CLEANUP_TRAP_CACHES variable; this workflow runs on GitHub-hosted ubuntu-latest with the default bundle and never sets that variable, so neither applies. Refs #72
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CodeQL workflow updates both ChangesCodeQL workflow update
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #72
Supersedes #65
Summary
github/codeql-action/initandgithub/codeql-action/analyzefromv3to the same commite4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81(v4.37.3).init, which would have leftanalyzeonv3. The CodeQL Action requires both sub-actions to come from the same release, so merging chore(deps): bump github/codeql-action/init from 3.37.3 to 4.37.3 #65 as-is would have split the versions and broken theanalyzejob — one of the checks that gates merges tomain.Changes
.github/workflows/codeql.ymlinit(line 25) andanalyze(line 31) both pinned toe4fba868(v4.37.3)Verification
v4.37.3andv4both dereference to commite4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81(both are annotated tags, so the tag object had to be dereferenced to its target).analyze/action.ymlis present at that commit, so one pinned SHA legitimately covers both sub-actions.codeql.ymlis the only file in.github/referencingcodeql-action— no other pin was left behind.codeql-actionsteps resolve to a single distinct SHA.v4 breaking changes — why they do not apply here
ubuntu-latest, which is well past that.CODEQL_ACTION_CLEANUP_TRAP_CACHESdeprecated: never set in this repository.Test plan
CodeQLandanalyzechecks pass on this PR — the real proof, since this PR changes the analyzer itselfFollow-up
Close #65 once this merges.
Summary by CodeRabbit