fix inverted xsd length facet check in anyURI and NOTATION holders#45
Closed
aizu-m wants to merge 1 commit into
Closed
fix inverted xsd length facet check in anyURI and NOTATION holders#45aizu-m wants to merge 1 commit into
aizu-m wants to merge 1 commit into
Conversation
Member
|
merged with 568c4c6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted while reading the *HolderEx facet checks side by side. The length-facet branch in JavaUriHolderEx.check reads:
It returns "invalid" when the length matches, the opposite of the minLength/maxLength branches right below it. JavaNotationHolderEx.check has the same defect, spelt as the double negative
!(v.length() != m).Both sit on the validate-on-set path (
set_text->check). I compiled an anyURI restricted withxs:length value="5"and set values with VALIDATE_ON_SET:So a correctly sized value is thrown out, and a wrong-length one slips past the length check entirely. JavaStringHolderEx and the validate_simpleval path already test
length != m, so I flipped both conditions to agree with them.Added a regression test that fails on trunk and passes with the change.