Add Trino cost profiling support and learned default parameters - #787
Open
JunWang222 wants to merge 22 commits into
Open
Add Trino cost profiling support and learned default parameters#787JunWang222 wants to merge 22 commits into
JunWang222 wants to merge 22 commits into
Conversation
…s into TrinoOperatorsIT
Contributor
|
@JunWang222 some conflicts here too |
zkaoudi
requested changes
Aug 14, 2026
zkaoudi
left a comment
zkaoudi
left a comment
Contributor
There was a problem hiding this comment.
please check some minor comments. Thank you @JunWang222 :)
| final Job job = wayangContext.createJob(null, wayangPlan); | ||
| // ILLEGAL: We blacklist the Spark platform, although we need it. | ||
| // ILLEGAL: We blacklist all platforms that can execute the plan. | ||
| job.getConfiguration().getPlatformProvider().addToBlacklist(Java.platform()); |
Contributor
There was a problem hiding this comment.
Java is added here to the black list, but only flink is added in the context (line 318). Do we need to add Java to the black list too?
| ```text | ||
| CPU load = alpha * number_of_rows + beta | ||
| ``` | ||
|
|
Contributor
There was a problem hiding this comment.
we can add here that alpha=10 and beta=800000 in the example configuration above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Trino cost profiling support, including:
The default parameters are intended as starting values. For accurate optimization on a specific machine or deployment, users should follow the profiling guide and regenerate parameters locally.