Repository navigation
[RELAY] Non-recursive Graph Vistor and Rewriter #4886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
bd14b04
First pass a defining a non-recursive Graph Vistor and Rewriter
bfabd87
Make CalcDep from Dead Code Elimination non-recursive
fd03421
Partially working, not passing all tests yet
31d0664
Refactor
7a68f0e
improve comments
6e4f7eb
respond to review comments on comments
0a80325
Fix a problem with default recursion for dataflow nodes
91747ef
implement ScopeMutator
mbrookhart 2d5ae42
convert forward_rewrite to ScopeMutator, remove DataflowMutator
mbrookhart 983f13c
rewrite ExprRewriter and convert fast_math to use it
mbrookhart 5f3addf
switch BiasAddSimplifier to ExprRewriter
mbrookhart f188e7e
respond to review comments
cd2084e
fix a typo in the iterative looping
mbrookhart 588daf3
add a regression test for GetExprRefCount issue
mbrookhart b1520c0
Normalize naming
mbrookhart 62ca9f5
fix lint
mbrookhart 25200bc
First pass a defining a non-recursive Graph Vistor and Rewriter
6e89865
Make CalcDep from Dead Code Elimination non-recursive
5cae577
Partially working, not passing all tests yet
55d6888
Refactor
6b95a91
improve comments
27d0760
respond to review comments on comments
bac5337
Fix a problem with default recursion for dataflow nodes
0af7763
implement ScopeMutator
mbrookhart 4934eae
convert forward_rewrite to ScopeMutator, remove DataflowMutator
mbrookhart e08119c
rewrite ExprRewriter and convert fast_math to use it
mbrookhart b1a496b
switch BiasAddSimplifier to ExprRewriter
mbrookhart c1fc3e8
respond to review comments
ada8bd1
fix a typo in the iterative looping
mbrookhart 509a087
add a regression test for GetExprRefCount issue
mbrookhart a7c8429
Normalize naming
mbrookhart ae3c62e
fix lint
mbrookhart dc89877
Merge branch 'mbrookhart/GraphVisitor' of github.com:mbrookhart/incub…
mbrookhart 517e83d
respond to review comments
mbrookhart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.