Skip to content

[DOC] CoreML frontend tutorial - #2667

Merged
yzhliu merged 4 commits into
apache:masterfrom
kazum:coreml-tutorial
Feb 27, 2019
Merged

yzhliu merged 4 commits into
apache:masterfrom
kazum:coreml-tutorial

Conversation

@kazum

@kazum kazum commented Feb 23, 2019

Copy link
Copy Markdown
Contributor

@zhreshold @zhiics, please help to review.

@kazum kazum mentioned this pull request Feb 23, 2019
8 tasks done
@zhiics

zhiics commented Feb 23, 2019

Copy link
Copy Markdown
Member

LGTM. @yzhliu Please take a look since you wrote the CoreML Relay frontend.

Comment thread tutorials/frontend/from_coreml.py Outdated
Comment thread tutorials/frontend/from_coreml.py Outdated
zhiics and others added 2 commits February 24, 2019 06:32
Co-Authored-By: kazum <morita.kazutaka@lab.ntt.co.jp>
Co-Authored-By: kazum <morita.kazutaka@lab.ntt.co.jp>
Comment thread tutorials/frontend/from_coreml.py Outdated
@kazum

kazum commented Feb 27, 2019

Copy link
Copy Markdown
Contributor Author

@yzhliu, addressed your comment. In addition, I added the original author @zhreshold to the author list. Can you take a look again?

@yzhliu yzhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge once CI is happy

@yzhliu
yzhliu merged commit 8091850 into apache:master Feb 27, 2019
@yzhliu

yzhliu commented Feb 27, 2019

Copy link
Copy Markdown
Member

Thanks @kazum

@kazum
kazum deleted the coreml-tutorial branch February 27, 2019 20:23
@yzhliu yzhliu mentioned this pull request Mar 2, 2019
9 of 28 tasks
wweic pushed a commit to neo-ai/tvm that referenced this pull request Mar 9, 2019
* [DOC] CoreML frontend tutorial

* Update tutorials/frontend/from_coreml.py

Co-Authored-By: kazum <morita.kazutaka@lab.ntt.co.jp>

* Update tutorials/frontend/from_coreml.py

Co-Authored-By: kazum <morita.kazutaka@lab.ntt.co.jp>

* Addressed comments and added the original author
wweic pushed a commit to neo-ai/tvm that referenced this pull request Mar 12, 2019
* [DOC] CoreML frontend tutorial

* Update tutorials/frontend/from_coreml.py

Co-Authored-By: kazum <morita.kazutaka@lab.ntt.co.jp>

* Update tutorials/frontend/from_coreml.py

Co-Authored-By: kazum <morita.kazutaka@lab.ntt.co.jp>

* Addressed comments and added the original author
wweic pushed a commit to neo-ai/tvm that referenced this pull request Mar 12, 2019
* [DOC] CoreML frontend tutorial

* Update tutorials/frontend/from_coreml.py

Co-Authored-By: kazum <morita.kazutaka@lab.ntt.co.jp>

* Update tutorials/frontend/from_coreml.py

Co-Authored-By: kazum <morita.kazutaka@lab.ntt.co.jp>

* Addressed comments and added the original author
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants