Skip to content

[BUGFIX] [Hybrid Script] fix in-correct value index in hybrid script - #2268

Merged
tqchen merged 4 commits into
apache:masterfrom
were:fix-value-idx
Dec 13, 2018
Merged

tqchen merged 4 commits into
apache:masterfrom
were:fix-value-idx

Conversation

@were

@were were commented Dec 11, 2018 •

Copy link
Copy Markdown
Contributor

@kevinthesun
My bad, I did not realize that it is possible that upper stream tensors have value_index which is not 0.

@were

were commented Dec 11, 2018

Copy link
Copy Markdown
Contributor Author

@tqchen @yzhliu Anyone can let this quick fix in so that Yao can move forward?

@tqchen

tqchen commented Dec 11, 2018

Copy link
Copy Markdown
Member

Please add a regression testcase

@were

were commented Dec 12, 2018

Copy link
Copy Markdown
Contributor Author

@tqchen Done.

@tqchen
tqchen merged commit 4bbf96e into apache:master Dec 13, 2018
@tqchen

tqchen commented Dec 13, 2018

Copy link
Copy Markdown
Member

Thanks, @kevinthesun @were , this is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants