Skip to content

[TIRx] Reject boolean div and mod #20412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nanmur wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[TIRx] Reject boolean div and mod #20412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/ir/prim/op.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,10 @@ PrimExpr mul(PrimExpr a, PrimExpr b, Span span) {
}

PrimExpr div(PrimExpr a, PrimExpr b, Span span) {
TVM_FFI_CHECK(!a.ty().MatchesCode(DLDataTypeCode::kDLBool), TypeError)
<< "Div does not support boolean data types, but got " << a.ty();
TVM_FFI_CHECK(!b.ty().MatchesCode(DLDataTypeCode::kDLBool), TypeError)
<< "Div does not support boolean data types, but got " << b.ty();
BinaryOpMatchTypes(a, b, span);
if (auto ret = prim::detail::TryConstFold<prim::Div>(a, b)) return ret.value();
return prim::Div(a, b, span);
Expand All @@ -407,6 +411,10 @@ PrimExpr truncdiv(PrimExpr a, PrimExpr b, Span span) {
}

PrimExpr truncmod(PrimExpr a, PrimExpr b, Span span) {
TVM_FFI_CHECK(!a.ty().MatchesCode(DLDataTypeCode::kDLBool), TypeError)
<< "Mod does not support boolean data types, but got " << a.ty();
TVM_FFI_CHECK(!b.ty().MatchesCode(DLDataTypeCode::kDLBool), TypeError)
<< "Mod does not support boolean data types, but got " << b.ty();
BinaryOpMatchTypes(a, b, span);
if (auto ret = prim::detail::TryConstFold<prim::Mod>(a, b)) return ret.value();
return prim::Mod(a, b, span);
Expand Down
24 changes: 24 additions & 0 deletions tests/python/tirx-base/test_tir_nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,30 @@ def test_divide_by_zero():
pass


@pytest.mark.parametrize("op", [tvm.tirx.div, tvm.tirx.truncmod])
@pytest.mark.parametrize("lhs_dtype,rhs_dtype", [("bool", "int32"), ("int32", "bool")])
def test_reject_boolean_divide_and_modulo(op, lhs_dtype, rhs_dtype):
lhs = tvm.tirx.const(True if lhs_dtype == "bool" else 1, lhs_dtype)
rhs = tvm.tirx.const(True if rhs_dtype == "bool" else 1, rhs_dtype)
with pytest.raises(TypeError, match="does not support boolean"):
op(lhs, rhs)


@pytest.mark.parametrize("dtype", ["float16", "float32", "float64"])
def test_allow_floating_point_modulo(dtype):
lhs = tvm.tirx.const(5.5, dtype)
rhs = tvm.tirx.const(2.0, dtype)
assert tvm.tirx.truncmod(lhs, rhs).ty.dtype == dtype


@pytest.mark.parametrize("op", [tvm.tirx.div, tvm.tirx.truncmod])
@pytest.mark.parametrize("dtype", ["bfloat16", "float8_e4m3fn", "float8_e5m2"])
def test_allow_nonstandard_floating_point_divide_and_modulo(op, dtype):
lhs = tvm.tirx.Var("lhs", dtype)
rhs = tvm.tirx.Var("rhs", dtype)
assert op(lhs, rhs).ty.dtype == dtype


def test_infinity():
assert str(tvm.tirx.infinity("float16")) == 'T.float16("inf")'
assert str(tvm.tirx.infinity("float32")) == 'T.float32("inf")'
Expand Down
Loading