Repository navigation
[Fix][DLight] Reject GEMV accesses unsupported by scheduling - #20122
Merged
tlopex merged 1 commit intoAug 17, 2026
Merged
Conversation
akaashrp
force-pushed
the
upstream/dlight-gemv-access-legality
branch
from
August 12, 2026 09:19
2696472 to
4f2ec96
Compare
akaashrp
changed the title
Make the generic GEMV rule decline normalized accesses whose sources do not map to individual block iterators. Also make LowBatchGEMV decline regions outside the point-access contract required by pad_einsum. Unsupported reductions remain available to other schedule rules or generic lowering.
akaashrp
force-pushed
the
upstream/dlight-gemv-access-legality
branch
from
August 13, 2026 03:06
4f2ec96 to
bc0c9cd
Compare
tlopex
approved these changes
Aug 17, 2026
wodylm
pushed a commit
to wodylm/mcTVM
that referenced
this pull request
Sep 15, 2026
…20122) DLight's GEMV schedule rules can recognize reductions whose buffer accesses do not satisfy the assumptions of subsequent scheduling steps. For generic GEMV, normalization may produce a composite access source that does not correspond to a block iterator. LowBatchGEMV can similarly accept non-point access regions that are unsupported by `Schedule.pad_einsum`. These cases currently raise an exception while applying the schedule. This PR: 1. Validates that each normalized GEMV access source maps to a block iterator. 2. Requires LowBatchGEMV read and write regions to be unit-extent point accesses before applying `pad_einsum`. 3. Adds tests for composite transposed-convolution accesses and non-einsum LowBatchGEMV accesses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DLight's GEMV schedule rules can recognize reductions whose buffer accesses do not satisfy the assumptions of subsequent scheduling steps. For generic GEMV, normalization may produce a composite access source that does not correspond to a block iterator. LowBatchGEMV can similarly accept non-point access regions that are unsupported by
Schedule.pad_einsum. These cases currently raise an exception while applying the schedule. This PR:pad_einsum.