Repository navigation
[Fix][WebGPU] Preserve read-only buffer access modes - #20113
Merged
Merged
Conversation
guan404ming
approved these changes
Aug 11, 2026
guan404ming
left a comment
guan404ming
left a comment
Member
There was a problem hiding this comment.
LGTM, verified in my local machine and work as expected. Thanks!
wodylm
pushed a commit
to wodylm/mcTVM
that referenced
this pull request
Sep 15, 2026
Preserve read-only WebGPU storage-buffer access modes after typed TIR buffer lowering. Resolve `DeclBuffer` aliases to their underlying pointer parameters and only emit `read_write` when the buffer is actually written. This prevents read-only metadata buffers from being misclassified and triggering WGSL uniform-control-flow validation errors around `workgroupBarrier`.
tqchen
pushed a commit
that referenced
this pull request
Oct 16, 2026
Preserve read-only WebGPU storage-buffer access modes after typed TIR buffer lowering. Resolve `DeclBuffer` aliases to their underlying pointer parameters and only emit `read_write` when the buffer is actually written. This prevents read-only metadata buffers from being misclassified and triggering WGSL uniform-control-flow validation errors around `workgroupBarrier`.
tqchen
pushed a commit
that referenced
this pull request
Oct 18, 2026
Preserve read-only WebGPU storage-buffer access modes after typed TIR buffer lowering. Resolve `DeclBuffer` aliases to their underlying pointer parameters and only emit `read_write` when the buffer is actually written. This prevents read-only metadata buffers from being misclassified and triggering WGSL uniform-control-flow validation errors around `workgroupBarrier`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve read-only WebGPU storage-buffer access modes after typed TIR buffer lowering. Resolve
DeclBufferaliases to their underlying pointer parameters and only emitread_writewhen the buffer is actually written. This prevents read-only metadata buffers from being misclassified and triggering WGSL uniform-control-flow validation errors aroundworkgroupBarrier.