Skip to content

[Tests] Replace remaining requires_* helpers with standard pytest - #19787

Merged
tqchen merged 1 commit into
apache:mainfrom
tlopex:phase-out-requires
Jun 16, 2026
Merged

tqchen merged 1 commit into
apache:mainfrom
tlopex:phase-out-requires

Conversation

@tlopex

@tlopex tlopex commented Jun 16, 2026

Copy link
Copy Markdown
Member

This pr is the Follow-up to #19777. This pr removes the last requires_* decorators so test gating is plain pytest everywhere, with no custom indirection left.

Replace the remaining requires_* decorators with standard pytest:
- requires_package -> module-level pytest.importorskip
- requires_hexagon_toolchain -> removed (unused)
- requires_adreno_* -> @pytest.mark.gpu + skipif

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors test decorators and markers across several TVM test files, removing custom decorators like requires_package and _adreno_requires in favor of standard pytest mechanisms such as pytest.importorskip and pytest.mark.skipif combined with @pytest.mark.gpu. Feedback was provided to guard the Adreno OpenCL/Vulkan runtime checks with tvm.runtime.enabled to prevent potential TVMError exceptions during test collection when TVM is compiled without OpenCL or Vulkan support.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tests/python/relax/backend/adreno/utils.py
@tqchen
tqchen merged commit 9011739 into apache:main Jun 16, 2026
9 checks passed
MasterJH5574 pushed a commit that referenced this pull request Jun 16, 2026
…9787)

This pr is the Follow-up to #19777. This pr removes the last
`requires_*` decorators so test gating is plain pytest everywhere, with
no custom indirection left.
tqchen pushed a commit that referenced this pull request Oct 16, 2026
…9787)

This pr is the Follow-up to #19777. This pr removes the last
`requires_*` decorators so test gating is plain pytest everywhere, with
no custom indirection left.
tqchen pushed a commit that referenced this pull request Oct 18, 2026
…9787)

This pr is the Follow-up to #19777. This pr removes the last
`requires_*` decorators so test gating is plain pytest everywhere, with
no custom indirection left.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants