Repository navigation
[Docs][CI] Bump tlcpack-sphinx-addon to restore search result summaries - #19782
Merged
tqchen merged 1 commit intoJun 15, 2026
Merged
Conversation
The docs search page (search.html) showed no per-result summaries and spammed "Failed to execute 'appendChild' on 'Node'" errors in the browser console (apache#19765). The addon's layout.html omitted the data-content_root attribute that Sphinx >= 7.2 searchtools.js reads via document.documentElement.dataset.content_root to fetch pages and build the summaries; with it undefined the summary fetch resolved to "undefined...html" (404), so no summary rendered and makeSearchSummary returned null into appendChild. tlc-pack/tlcpack-sphinx-addon#14 adds the attribute. Bump the pin used by the docs (ci_gpu) image from 99c6947 to dded1a3 to pick it up.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the commit hash of the tlcpack-sphinx-addon package in the Ubuntu Sphinx installation script (docker/install/ubuntu_install_sphinx.sh) to dded1a3fbaf549485d8f7bb3f79ecb0484a11629. There are no review comments, so I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
tqchen
approved these changes
Jun 15, 2026
MasterJH5574
pushed a commit
that referenced
this pull request
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs search page (search.html) showed no per-result summaries and spammed "Failed to execute 'appendChild' on 'Node'" errors in the browser console (#19765). The addon's layout.html omitted the data-content_root attribute that Sphinx >= 7.2 searchtools.js reads via document.documentElement.dataset.content_root to fetch pages and build the summaries; with it undefined the summary fetch resolved to "undefined...html" (404), so no summary rendered and makeSearchSummary returned null into appendChild.
tlc-pack/tlcpack-sphinx-addon#14 adds the attribute. Bump the pin used by the docs (ci_gpu) image from 99c6947 to dded1a3 to pick it up.