Repository navigation
[TIRX][Tests] Fix LLVM version gate for vectorized lround - #19753
Merged
Merged
Conversation
…ot 21) LLVM 20 added vector support for llvm.lround/llvm.llround. In LLVM release/19.x, the IR Verifier still rejects vector operands/results for these intrinsics with "Intrinsic does not support vectors". In release/20.x, that verifier check was removed, and LLVM 20.1 compiles the vectorized lround module successfully. Update the test gate so LLVM <= 19 still exercises the expected failure path, while LLVM 20+ uses the successful compile path.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
tqchen
approved these changes
Jun 13, 2026
MasterJH5574
pushed a commit
to MasterJH5574/tvm
that referenced
this pull request
Jun 15, 2026
LLVM 20 added vector support for llvm.lround/llvm.llround. In LLVM release/19.x, the IR Verifier still rejects vector operands/results for these intrinsics with "Intrinsic does not support vectors". In release/20.x, that verifier check was removed, and LLVM 20.1 compiles the vectorized lround module successfully. This updates the test gate so LLVM <= 19 still exercises the expected failure path, while LLVM 20+ uses the successful compile path. Co-authored-by: tlopexh <tlopexh@users.noreply.github.com> (cherry picked from commit 235387d)
MasterJH5574
pushed a commit
to MasterJH5574/tvm
that referenced
this pull request
Jun 15, 2026
LLVM 20 added vector support for llvm.lround/llvm.llround. In LLVM release/19.x, the IR Verifier still rejects vector operands/results for these intrinsics with "Intrinsic does not support vectors". In release/20.x, that verifier check was removed, and LLVM 20.1 compiles the vectorized lround module successfully. This updates the test gate so LLVM <= 19 still exercises the expected failure path, while LLVM 20+ uses the successful compile path. Co-authored-by: tlopexh <tlopexh@users.noreply.github.com> (cherry picked from commit 235387d)
tqchen
pushed a commit
that referenced
this pull request
Oct 16, 2026
LLVM 20 added vector support for llvm.lround/llvm.llround. In LLVM release/19.x, the IR Verifier still rejects vector operands/results for these intrinsics with "Intrinsic does not support vectors". In release/20.x, that verifier check was removed, and LLVM 20.1 compiles the vectorized lround module successfully. This updates the test gate so LLVM <= 19 still exercises the expected failure path, while LLVM 20+ uses the successful compile path. Co-authored-by: tlopexh <tlopexh@users.noreply.github.com>
tqchen
pushed a commit
that referenced
this pull request
Oct 18, 2026
LLVM 20 added vector support for llvm.lround/llvm.llround. In LLVM release/19.x, the IR Verifier still rejects vector operands/results for these intrinsics with "Intrinsic does not support vectors". In release/20.x, that verifier check was removed, and LLVM 20.1 compiles the vectorized lround module successfully. This updates the test gate so LLVM <= 19 still exercises the expected failure path, while LLVM 20+ uses the successful compile path. Co-authored-by: tlopexh <tlopexh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLVM 20 added vector support for llvm.lround/llvm.llround. In LLVM release/19.x, the IR Verifier still rejects vector operands/results for these intrinsics with "Intrinsic does not support vectors". In release/20.x, that verifier check was removed, and LLVM 20.1 compiles the vectorized lround module successfully.
This updates the test gate so LLVM <= 19 still exercises the expected failure path, while LLVM 20+ uses the successful compile path.