Repository navigation
[Tests][Disco] Skip CCL tests when runtime support is absent - #19724
Merged
Merged
Conversation
The disco CCL tests called tvm.get_global_func("runtime.disco.compiled_ccl")
at module import time, which raises ValueError on TVM builds without Disco
CCL support (e.g. published wheels), failing pytest collection. Resolve the
function with allow_missing=True and skip the module when it is absent.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Disco CCL tests to gracefully skip execution when Disco CCL is not enabled in the TVM build. However, in test_ccl.py, wrapping the result of _compiled_ccl() in a list creates an unintended nested list structure, which will cause parametrization to fail. It is recommended to assign _ccl directly to the return value of _compiled_ccl().
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
tqchen
approved these changes
Jun 10, 2026
MasterJH5574
pushed a commit
to MasterJH5574/tvm
that referenced
this pull request
Jun 15, 2026
…19724) The disco CCL tests called tvm.get_global_func("runtime.disco.compiled_ccl") at module import time, which raises ValueError on TVM builds without Disco CCL support (e.g. published wheels), failing pytest collection. Resolve the function with allow_missing=True and skip the module when it is absent. (cherry picked from commit 3d95dec)
MasterJH5574
pushed a commit
to MasterJH5574/tvm
that referenced
this pull request
Jun 15, 2026
…19724) The disco CCL tests called tvm.get_global_func("runtime.disco.compiled_ccl") at module import time, which raises ValueError on TVM builds without Disco CCL support (e.g. published wheels), failing pytest collection. Resolve the function with allow_missing=True and skip the module when it is absent. (cherry picked from commit 3d95dec)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The disco CCL tests called tvm.get_global_func("runtime.disco.compiled_ccl") at module import time, which raises ValueError on TVM builds without Disco CCL support (e.g. published wheels), failing pytest collection. Resolve the function with allow_missing=True and skip the module when it is absent.