Repository navigation
[Python] Refactor pyproject.toml dependencies - #19723
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors project dependencies in pyproject.toml by moving psutil from main dependencies to optional and test groups, renaming importer-pytorch to importer-torch, and updating the all extra. In python/tvm/s_tir/meta_schedule/utils.py, the psutil import is moved inline. Feedback suggests catching ImportError when importing psutil inline to fall back to os.cpu_count(), and keeping importer-pytorch as an alias to avoid breaking backward compatibility.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
tlopex
force-pushed
the
lazy-import-psutil-meta-schedule
branch
4 times, most recently
from
June 11, 2026 00:50
095d0c6 to
30becbe
Compare
A plain `import tvm` hard-required psutil: the import chain tvm -> relax -> relax/pipeline.py -> s_tir.meta_schedule -> meta_schedule/utils.py reached a top-level `import psutil`, even though the only use in that module is psutil.cpu_count() for the meta schedule search. All other call sites (popen_pool, disco.process_pool, rpc.server) already import psutil lazily inside the functions that need it. - Move `import psutil` in s_tir/meta_schedule/utils.py from module level into _cpu_count_impl with an actionable error message, and drop psutil from the core dependencies. - Drop the importer extras: users importing torch/onnx/tflite models already have the corresponding framework installed, so declaring it on TVM's side is redundant. - Drop the coreml extra: the CoreML BYOC backend additionally requires a USE_COREML=ON build (off by default and in the published wheels) and Xcode's coremlcompiler, so the extra alone could not enable the feature. Its lazy coremltools import now raises an actionable error instead. - Organize the remaining extras by feature: torch, cuda (cuda-python for NVRTC JIT), meta-schedule (xgboost), popen-pool (psutil, cloudpickle), rpc (tornado, psutil, cloudpickle), and all (the union of the lightweight feature deps). - Add a popen-pool dependency group (cloudpickle, psutil) included by the test group, covering the PopenPool worker deps when running the test suite from a source checkout. - Give the onnx/torch/tflite frontends actionable ImportErrors too. The onnx frontend's existing "Unable to import onnx" guards were unreachable: the unguarded module-level import failed first.
tlopex
force-pushed
the
lazy-import-psutil-meta-schedule
branch
from
June 11, 2026 00:50
30becbe to
0e8e0df
Compare
tqchen
approved these changes
Jun 11, 2026
MasterJH5574
pushed a commit
to MasterJH5574/tvm
that referenced
this pull request
Jun 15, 2026
This pr refactors `pyproject.toml` and deletes redundant dependencies (cherry picked from commit a4a2bf5)
MasterJH5574
pushed a commit
to MasterJH5574/tvm
that referenced
this pull request
Jun 15, 2026
This pr refactors `pyproject.toml` and deletes redundant dependencies (cherry picked from commit a4a2bf5)
tqchen
pushed a commit
that referenced
this pull request
Oct 16, 2026
This pr refactors `pyproject.toml` and deletes redundant dependencies
tqchen
pushed a commit
that referenced
this pull request
Oct 18, 2026
This pr refactors `pyproject.toml` and deletes redundant dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr refactors
pyproject.tomland deletes redundant dependencies