Skip to content

[BUG] Fix incorrect libcuda.so found by cmake when multiple versions of CUDA exist - #1788

Merged
tqchen merged 3 commits into
apache:masterfrom
junrushao:fix-cmake
Oct 1, 2018
Merged

tqchen merged 3 commits into
apache:masterfrom
junrushao:fix-cmake

Conversation

@junrushao

@junrushao junrushao commented Oct 1, 2018 •

Copy link
Copy Markdown
Member

This PR contains a very minor fix and a modification in cmake.

  1. Enforce NO_DEFAULT_PATH when CUDA path is found. This particularly resolves my issue when building on the server in my university: when multiple CUDA versions exist, the original FindCUDA.cmake could possibly use incorrect libcuda.so.
  2. Print the dependencies found by FindXXXX explicitly. This could make it more friendly to developers who fail to build TVM due to dependency issues.

I posted details of this issue on the TVM forum: https://discuss.tvm.ai/t/incorrect-libcuda-so-when-multiple-versions-of-cuda-exist-problem-and-solution/886.

@junrushao

junrushao commented Oct 1, 2018 •

Copy link
Copy Markdown
Member Author

Re-triggering the CI: test_topi_matmul.test_matmul is flaky (See http://ci.tvm.ai:8080/blue/organizations/jenkins/tvm/detail/PR-1788/1/pipeline).

Related issue: #1784

@junrushao

junrushao commented Oct 1, 2018 •

Copy link
Copy Markdown
Member Author

A side note: It is undefined behavior to exit -1 in shells. Exit code should be unsigned int in [0, 255]. (http://pubs.opengroup.org/onlinepubs/7990989775/xcu/chap2.html#tag_001_014_007)

I noticed that this problem occurs every time when CI fails, so is it intended to return an undefined error code?

@junrushao

Copy link
Copy Markdown
Member Author

@tqchen Could you help review this? Thanks!

@tqchen
tqchen merged commit e928109 into apache:master Oct 1, 2018
FrozenGene pushed a commit to FrozenGene/tvm that referenced this pull request Dec 27, 2018
@junrushao
junrushao deleted the fix-cmake branch January 6, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants