Skip to content

[Graph Tuner]Core Functionality for Graph Tuner - #1586

Closed
kevinthesun wants to merge 12 commits into
apache:masterfrom
kevinthesun:GraphTuner
Closed

kevinthesun wants to merge 12 commits into
apache:masterfrom
kevinthesun:GraphTuner

Conversation

@kevinthesun

Copy link
Copy Markdown
Contributor

This is core function for graph tuner.
Detailed information and RFC: #1585

@tqchen @yidawang @yzhliu @merrymercy @Laurawly

@@ -0,0 +1,410 @@
# pylint: disable=too-many-arguments,too-many-locals,too-many-statements,too-many-instance-attributes,too-many-branches,too-many-nested-blocks

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't put these on top of a file. Move them under specific classes or functions, where pylint should be disabled for a certain reason.

@@ -0,0 +1,198 @@
# pylint: disable=import-error,too-many-locals,too-many-statements,too-many-branches,arguments-differ,unused-variable

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move them under specific classes or functions, where pylint should be disabled for a certain reason.

@tqchen

tqchen commented Oct 28, 2018

Copy link
Copy Markdown
Member

close for now due to inactive status, feel free to reopen when we bring in new changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants