Skip to content

[TESTS] Hardcode target and device when getting tvm output #8565

Closed
Closed
[TESTS] Hardcode target and device when getting tvm output#8565

Description

@CaptainDuke
CaptainDuke
opened on Jul 27, 2021

tvm/tests/python/frontend/onnx/test_forward.py

Lines 81 to 84 in 3445532

"""Generic function to execute and get tvm output"""
# TODO: Resolve the issues and remove the following lines
target = "llvm"
device = tvm.cpu(0)

I comment the code but test case test_gemm failed. It seems onnx_runtime and tvm differ on the precision.

Activity

  1. masahi commented on Jul 27, 2021

    @masahi
    masahi
    on Jul 27, 2021
    Member

    cc @mbrookhart @jwfromm I remember we found this problem before and fixed it then...

  2. electriclilies commented on Jul 27, 2021

    @electriclilies
    electriclilies
    on Jul 27, 2021
    Contributor

    Yeah, this hardcode shouldn't be there. @mbrookhart and I definitely removed it (or tried to)..

  3. mbrookhart commented on Jul 27, 2021

    @mbrookhart
    mbrookhart
    on Jul 27, 2021
    Contributor

    :/ I don't see the removal of the hard-coded target in the PR we did. https://github.com/apache/tvm/pull/7438/files

    But I could have sworn it was in there. Perhaps we messed up a rebase?

  4. masahi commented on Sep 7, 2021

    @masahi
    masahi
    on Sep 7, 2021
    Member

    Looks like it was fixed in #8621

  5. masahi
    closed this as completedon Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions