Skip to content

Mod constant folding in canonical.cc gives incorrect result #2486

Closed
Closed
Mod constant folding in canonical.cc gives incorrect result#2486

Description

@derisavi
derisavi
opened on Jan 22, 2019

This is happening because of a typo in line 366 below https://github.com/dmlc/tvm/blob/0806b69e3fb136226fa1dafad00bd2c606cc998d/src/arithmetic/canonical.cc#L356-L366 Instead of mod-ing the two operands, they are being multiplied.

Activity

  1. tqchen
    closed this as completedin #2487on Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions