Skip to content

[RFC] Streamline the relay build and optimize interface #2449

Description

@tqchen

As per #2361 , the build now takes an additional parameter(fallback_device). This is an RFC to discuss the interface of the build.

In particular, there is a dangerous trend in adding compilation related options to the interface itself, we can imagine that additional parameters will get added when we want more options, making build and optimize harder to maintain, this happened in the past in XGBoost project, whose train interface have an explosive growth of options that we lose track of.

I want to propose a discussion on the build interface, in particular, if we can keep additional pass options in build config, and keep a clean, consistent build interface with target, target_host and params.

cc @zhiics @jroesch @yzhliu

Activity

  1. zhiics commented on Jan 17, 2019

    @zhiics
    Member

    Yes, I am actually also aware of this. Another case may need again to extend the API is when we have different annotation schemes. Adding options looks a better way to me.

  2. tqchen commented on Jan 17, 2019

    @tqchen
    MemberAuthor

    @zhiics can you send a refactor patch then?

  3. zhiics commented on Jan 17, 2019

    @zhiics
    Member

    Sure. I will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions