Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions superset/sql/dialects/firebolt.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ class Generator(generator.Generator):
Custom generator for Firebolt.
"""

STAR_EXCEPT = "EXCLUDE"

TYPE_MAPPING = {
**generator.Generator.TYPE_MAPPING,
exp.DataType.Type.VARBINARY: "BYTEA",
Expand Down
62 changes: 62 additions & 0 deletions tests/unit_tests/sql/test_firebolt_dialect.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

"""Tests for Firebolt dialect support in sqlglot."""

from superset.sql.parse import SQLScript


def test_firebolt_exclude_syntax() -> None:
"""Test that Firebolt EXCLUDE syntax is preserved (not transformed to EXCEPT)."""
sql = "SELECT g.* EXCLUDE (source_file_timestamp) FROM public.games g"
script = SQLScript(sql, "firebolt")

generated = script.format()
assert "EXCLUDE" in generated
Comment thread
alexandrusoare marked this conversation as resolved.
Resolved
assert "EXCEPT" not in generated
assert "source_file_timestamp" in generated


def test_firebolt_exclude_multiple_columns() -> None:
"""Test EXCLUDE with multiple columns."""
sql = "SELECT * EXCLUDE (col1, col2, col3) FROM my_table"
script = SQLScript(sql, "firebolt")

generated = script.format()
assert "EXCLUDE" in generated
Comment thread
alexandrusoare marked this conversation as resolved.
Resolved
assert "EXCEPT" not in generated
assert "col1" in generated
assert "col2" in generated
assert "col3" in generated


def test_firebolt_sql_parsing() -> None:
"""Test that Firebolt SQL can be parsed without errors."""
sql = "SELECT * FROM my_table LIMIT 10"
script = SQLScript(sql, "firebolt")
assert len(script.statements) == 1
assert not script.has_mutation()


def test_firebolt_not_in_parenthesized() -> None:
"""Test that NOT IN is properly parenthesized in Firebolt."""
sql = "SELECT * FROM my_table WHERE id NOT IN (1, 2, 3)"
script = SQLScript(sql, "firebolt")

generated = script.format()
assert "NOT" in generated
assert "IN" in generated
Loading