Repository navigation
Conversation
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
dosubot
Bot
added
the
data:connect
|
CodeAnt AI finished reviewing your PR. |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This PR is related to SIP-195 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #37307 +/- ##
===========================================
+ Coverage 0 67.60% +67.60%
===========================================
Files 0 645 +645
Lines 0 48335 +48335
Branches 0 5300 +5300
===========================================
+ Hits 0 32678 +32678
- Misses 0 14366 +14366
- Partials 0 1291 +1291
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #3a496b
Actionable Suggestions - 2
-
docs/docs/configuration/databases.mdx - 1
- Invalid connection string · Line 1046-1046
-
superset/db_engine_specs/mongodb.py - 1
- Incorrect time grain handling · Line 44-58
Review Details
-
Files reviewed - 3 · Commit Range:
21d3899..21d3899- docs/docs/configuration/databases.mdx
- superset/db_engine_specs/mongodb.py
- tests/unit_tests/db_engine_specs/test_mongodb.py
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
AI Code Review powered by
Code Review Agent Run #4bf415Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
There was a problem hiding this comment.
Pull request overview
This PR adds support for MongoDB as a database engine in Superset, enabling users to connect to MongoDB databases and query collections using SQL through the PyMongoSQL dialect.
Changes:
- Adds
MongoDBEngineSpecclass with datetime conversion methods and time grain expressions - Implements comprehensive unit tests for the MongoDB engine specification
- Documents MongoDB connection setup and requirements
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| superset/db_engine_specs/mongodb.py | New MongoDB engine specification with SQLite-like datetime functions and time grain expressions |
| tests/unit_tests/db_engine_specs/test_mongodb.py | Unit tests for datetime conversion, epoch handling, time grain expressions, and engine metadata |
| docs/docs/configuration/databases.mdx | Documentation for MongoDB connection strings and PyMongoSQL installation |
There was a problem hiding this comment.
Code Review Agent Run #c91ae0
Actionable Suggestions - 1
-
tests/unit_tests/db_engine_specs/test_mongodb.py - 1
- Test expectation mismatch · Line 75-78
Review Details
-
Files reviewed - 3 · Commit Range:
10cd4ac..7a13cf1- docs/docs/configuration/databases.mdx
- superset/db_engine_specs/mongodb.py
- tests/unit_tests/db_engine_specs/test_mongodb.py
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
AI Code Review powered by
|
Hi @passren - please take a look at #36805 which was just merged a half-hour ago. That was a big improvement to how we generate documentation about databases, but it might require you to refactor some of your work to fit that new template. Please try merging/rebasing to incorporate those changes and reconcile. |
Code Review Agent Run #144ff5Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
|
Yep... sorry for the bad timing on #36805 but now with the proper metadata in the engine spec (and the logo) the docs (and Superset home page) will build themselves automatically. |
Haha... no worries at all. I'm looking at this PR. It's pretty straightforward. |
d2a6fc0 to
87bbd54
Compare
SUMMARY
Add MongoDB database engine specification, enabling users to connect to MongoDB databases and write SQL queries on MongoDB collections using the PyMongoSQL dialect.
This implementation:
MongoDBEngineSpecclass that extendsBaseEngineSpecwith MongoDB-specific configurationsconvert_dttmandepoch_to_dttm) for MongoDB compatibilityBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A - Backend database engine support addition, no UI changes
TESTING INSTRUCTIONS
Run unit tests for tests/unit_tests/db_engine_specs/test_mongodb.py
Integration Test in UI
ADDITIONAL INFORMATION