fix(dataset-editor): add missing Data type label in calculated columns tab by massucattoj · Pull Request #37165 · apache/superset

massucattoj · 2026-01-15T10:33:53Z

SUMMARY

The "Data type" field in the calculated columns tab of the dataset editor was missing its label. This was caused by using the Select component which doesn't render form labels passed via props. Fixed by replacing Select with SelectControl, which includes ControlHeader for proper label rendering - matching the pattern used by other fields in the same form.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

AFTER:

TESTING INSTRUCTIONS

Go to the dataset list
Click edit on any dataset
Switch to the calculated columns tab
Add an item
You will see now the Data Type select field.

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

…s tab

codeant-ai-for-open-source · 2026-01-15T10:33:59Z

CodeAnt AI is reviewing your PR.

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

bito-code-review · 2026-01-15T10:34:04Z

Code Review Agent Run #52fe9a

Actionable Suggestions - 0

Review Details

Files reviewed - 1 · Commit Range: c5fae26..c5fae26
- superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.jsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

codeant-ai-for-open-source · 2026-01-15T10:36:21Z

CodeAnt AI finished reviewing your PR.

netlify · 2026-01-15T10:37:17Z

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	`c5fae26`
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/6968c295e7fb480008c26a48
😎 Deploy Preview	https://deploy-preview-37165--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

geido · 2026-01-16T12:05:16Z

                label={t('Data type')}
                control={
-                  <Select
+                  <SelectControl


I am not sure I am clear about why Select would not handle this properly. The Field component should care about the label to be displayed and the Select should work ok with this too. Is there a deeper issue going on in the components?

Looking a little bit deeper and yes, the Fieldcomponent correctly passes the label prop to child. However, the raw Select component uses a header prop for displaying labels, not a label. The SelectControl wrapper handles this by converting the label prop into a ControlHeader and passing it as the header prop that Select expects.

But yes there is a way to keep the Select component here, that is add this header prop. I'll use the old component with the new prop

bito-code-review · 2026-01-16T12:06:51Z

Based on the PR diff, the change replaces the generic Select component with SelectControl, which is likely the standardized control for Superset forms. This ensures better integration with the Field component for proper label display and form behavior. A deeper issue might be that Select lacks support for props like freeForm, potentially affecting functionality beyond labeling.

codeant-ai-for-open-source · 2026-01-19T12:49:04Z

CodeAnt AI is running Incremental review

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

codeant-ai-for-open-source · 2026-01-19T12:51:42Z

                  <Select
                    ariaLabel={t('Data type')}
+                    header={<FormLabel>{t('Data type')}</FormLabel>}


Suggestion: The added JSX uses the generic Select component which doesn't integrate with the form Field API and likely won't wire the value/onChange into the dataset column item; replace the Select usage with SelectControl and provide the controlId so the Field/Fieldset will correctly bind this input to the type field (this ensures the value is saved and the label is handled by the form control). [possible bug]

Severity Level: Critical 🚨

- ❌ Data type may not persist on calculated columns. - ⚠️ Dataset editor form binding inconsistent. - ⚠️ Users may lose edits when saving dataset.

Suggested change

<Select

ariaLabel={t('Data type')}

header={<FormLabel>{t('Data type')}</FormLabel>}

<SelectControl

controlId="type"

ariaLabel={t('Data type')}

Steps of Reproduction ✅

1. Open superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.jsx and find the Field for "type" in the calculated-columns expandFieldset. The control JSX is at hunk lines 317-324 (317 <Select ... 324 />). 2. Note the pattern used elsewhere in this file: controls wired to fields typically use form-aware controls (e.g., TextControl has controlId set at lines ~296-300 for "verbose_name"). Those controls integrate with Field/Fieldset binding. 3. Start the web app, go to dataset list, click Edit on a dataset, switch to Calculated columns tab (the render for this tab mounts ColumnCollectionTable with allowEditDataType enabled — see the render of the Calculated columns tab where ColumnCollectionTable is rendered). 4. Add or edit a calculated column and change the Data type using the rendered Select (the JSX at lines 317-324). Because the code uses the generic Select without controlId/form-binding semantics, the Field/Fieldset machinery is not receiving input through the same API other controls use. This can be observed by comparing other Field controls in the same file that supply controlId (e.g., TextControl at lines ~296-300). Replacing the JSX with <SelectControl controlId="type" .../> at the same location binds this input to the Field API, ensuring values are persisted when the dataset is saved.

Prompt for AI Agent 🤖

This is a comment left during a code review. **Path:** superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.jsx **Line:** 317:319 **Comment:** *Possible Bug: The added JSX uses the generic `Select` component which doesn't integrate with the form Field API and likely won't wire the value/onChange into the dataset column item; replace the `Select` usage with `SelectControl` and provide the `controlId` so the Field/Fieldset will correctly bind this input to the `type` field (this ensures the value is saved and the label is handled by the form control). Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.

codeant-ai-for-open-source · 2026-01-19T12:51:46Z

CodeAnt AI Incremental review completed.

VanessaGiannoni

LGTM

bito-code-review · 2026-01-19T13:58:31Z

Code Review Agent Run #92d95d

Actionable Suggestions - 0

Review Details

Files reviewed - 1 · Commit Range: c5fae26..1014e4e
- superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.jsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

rusackas · 2026-01-21T19:07:13Z

Almost merged this, but spotted some suggested cahnges. Please slap a change request or hold label on this if you don't want a trigger happy merge to occur ;)

codeant-ai-for-open-source · 2026-01-22T00:00:24Z

CodeAnt AI is running Incremental review

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

massucattoj · 2026-01-22T00:00:50Z

Almost merged this, but spotted some suggested cahnges. Please slap a change request or hold label on this if you don't want a trigger happy merge to occur ;)

You can merge it now, thanks!

codeant-ai-for-open-source · 2026-01-22T00:02:27Z

CodeAnt AI Incremental review completed.

bito-code-review · 2026-01-22T01:02:05Z

Code Review Agent Run #892da7

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: 1014e4e..b25e7f9
- superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.jsx
- superset-frontend/src/components/Datasource/components/DatasourceEditor/tests/DatasourceEditor.test.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

…s tab (#37165) (cherry picked from commit 04c5517)

…s tab (apache#37165)

fix(dataset-editor): add missing Data type label in calculated column…

c5fae26

…s tab

pull-request-size Bot added the size/XS label Jan 15, 2026

dosubot Bot added the change:frontend Requires changing the frontend label Jan 15, 2026

geido reviewed Jan 16, 2026

View reviewed changes

back to old component and add missing prop

1014e4e

massucattoj requested a review from geido January 19, 2026 12:49

codeant-ai-for-open-source Bot reviewed Jan 19, 2026

View reviewed changes

VanessaGiannoni approved these changes Jan 19, 2026

View reviewed changes

geido approved these changes Jan 20, 2026

View reviewed changes

Comment thread superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.jsx

test/add-unit-test-to-data-label

b25e7f9

pull-request-size Bot added size/S and removed size/XS labels Jan 22, 2026

rusackas merged commit 04c5517 into apache:master Jan 23, 2026
76 of 77 checks passed

sadpandajoe pushed a commit that referenced this pull request Jan 23, 2026

fix(dataset-editor): add missing Data type label in calculated column…

054040b

…s tab (#37165) (cherry picked from commit 04c5517)

sadpandajoe added the v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch label Jan 23, 2026

dosubot Bot mentioned this pull request Feb 3, 2026

fix(dataset-editor): Calculated columns excluded from Currency Code column dropdown #37620

Closed

alex-poor pushed a commit to alex-poor/superset that referenced this pull request Mar 15, 2026

fix(dataset-editor): add missing Data type label in calculated column…

9849db0

…s tab (apache#37165)

qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026

fix(dataset-editor): add missing Data type label in calculated column…

b61d797

…s tab (apache#37165)

Conversation

massucattoj commented Jan 15, 2026

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

codeant-ai-for-open-source Bot commented Jan 15, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

bito-code-review Bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #52fe9a

Uh oh!

codeant-ai-for-open-source Bot commented Jan 15, 2026

Uh oh!

netlify Bot commented Jan 15, 2026

✅ Deploy Preview for superset-docs-preview ready!

Uh oh!

geido Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

massucattoj Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

bito-code-review Bot commented Jan 16, 2026

Uh oh!

codeant-ai-for-open-source Bot commented Jan 19, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

codeant-ai-for-open-source Bot Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

codeant-ai-for-open-source Bot commented Jan 19, 2026

Uh oh!

VanessaGiannoni left a comment

Choose a reason for hiding this comment

Uh oh!

bito-code-review Bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #92d95d

Uh oh!

Uh oh!

rusackas commented Jan 21, 2026

Uh oh!

codeant-ai-for-open-source Bot commented Jan 22, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

massucattoj commented Jan 22, 2026

Uh oh!

codeant-ai-for-open-source Bot commented Jan 22, 2026

Uh oh!

bito-code-review Bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #892da7

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bito-code-review Bot commented Jan 15, 2026 •

edited

Loading

bito-code-review Bot commented Jan 19, 2026 •

edited

Loading

bito-code-review Bot commented Jan 22, 2026 •

edited

Loading