fix: address comments

66b0a73

Select commit

Loading

Failed to load commit list.

Uh oh!

There was an error while loading. Please reload this page.

🎪 Superset Showtime on: pull_request_target 1

🎪 Sync PR to desired state

Pull Request Labeler on: pull_request_target

labeler

CodeQL on: pull_request

Analyze (python)

Analyze (javascript)

Dependency Review on: pull_request

dependency-review

python-dependency-liccheck

Check python dependencies on: pull_request

check-python-deps

E2E on: pull_request 48

cypress-matrix (0, chrome)

cypress-matrix (0, chrome, /app/prefix)

cypress-matrix (1, chrome)

cypress-matrix (1, chrome, /app/prefix)

cypress-matrix (2, chrome)

cypress-matrix (2, chrome, /app/prefix)

cypress-matrix (3, chrome)

cypress-matrix (3, chrome, /app/prefix)

cypress-matrix (4, chrome)

cypress-matrix (4, chrome, /app/prefix)

cypress-matrix (5, chrome)

cypress-matrix (5, chrome, /app/prefix)

Superset Extensions CLI Package Tests on: pull_request

test-superset-extensions-cli-package (previous)

test-superset-extensions-cli-package (current)

test-superset-extensions-cli-package (next)

Python Presto/Hive on: pull_request

test-postgres-presto

test-postgres-hive

Playwright E2E Tests on: pull_request 6

playwright-tests (chromium)

playwright-tests (chromium, /app/prefix)

Frontend Build CI (unit tests, linting & sanity checks) on: pull_request

frontend-build

sharded-jest-tests

lint-frontend

validate-frontend

report-coverage

Superset App CLI tests on: pull_request

test-load-examples

PR Lint on: pull_request

lint-check

Python-Unit on: pull_request

unit-tests (previous)

unit-tests (current)

unit-tests (next)

Translations on: pull_request

frontend-check-translations

babel-extract

Build & publish docker images on: pull_request

setup_matrix

docker-compose-image-tag

docker-build (dev)

docker-build (lean)

Hold Label Check on: pull_request

check-hold-label

pre-commit checks on: pull_request

pre-commit (current)

pre-commit (previous)

pre-commit (next)

License Template Check on: pull_request

License Check

Python-Integration on: pull_request

test-mysql

test-postgres (current)

test-postgres (previous)

test-postgres (next)

test-sqlite

Validate All GitHub Actions on: pull_request

validate-all-ghas

Code scanning results

CodeQL

🎪 Superset Showtime on: pull_request_target 1

🎪 Sync PR to desired state

Hold Label Check on: pull_request

check-hold-label

Ephemeral env workflow [DEPRECATED] on: pull_request_target

Evaluate ephemeral env label trigger

ephemeral-docker-build

Spin up an ephemeral environment

🎪 Superset Showtime on: pull_request_target 1

🎪 Sync PR to desired state

fix: address comments

Uh oh!

Select a check to view from the sidebar