refactor(Dropdown): Migrate Dropdown to Ant Design 5

[msyavuz]

SUMMARY

Migrate Dropdown to Ant Design 5

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

Check for visual changes manually

ADDITIONAL INFORMATION

• Has associated issue: Fixes Ant Design 5: Upgrade Dropdown component #31952
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

[kgabryje]

In dashboard menu, submenu Download, both menu items get highlighted when I hover over one of them. Other menus and submenus don't have that bug.

[msyavuz]

Are you on the branch latest? I remember fixing that bug and it seems to be working

[kgabryje]

Not sure if it was like that before, but any chance we could make it stay in 1 line? Or if it needs to wrap, make it stay in the column with text and not go into the column with icons? If it's not a regression, we can fix it in a separate PR

[kgabryje]

Is the filter bar orientation submenu supposed to be a different color?

[kgabryje]

Again, not sure if it's present on master or not, but we shouldn't display a divider here if there's only "Set up report" button available (both in Explore and Dashboard)

[kgabryje]

In dashboard menu, submenu Download, both menu items get highlighted when I hover over one of them. Other menus and submenus don't have that bug.

Similar issue in Explore:

[kgabryje]

Are you on the branch latest? I remember fixing that bug and it seems to be working

Oh interesting... I'm on sha 6b62b6 (fix(test): change the role)

I double checked, I can repro this issue on any dashboard. The actions connected to those buttons work fine though

[msyavuz]

Not sure if it was like that before, but any chance we could make it stay in 1 line? Or if it needs to wrap, make it stay in the column with text and not go into the column with icons? If it's not a regression, we can fix it in a separate PR

That was regression. Fixed it now!

Is the filter bar orientation submenu supposed to be a different color?

Yes, that was the same on master as well.

Again, not sure if it's present on master or not, but we shouldn't display a divider here if there's only "Set up report" button available (both in Explore and Dashboard)

This was also present in master

Oh interesting... I'm on sha 6b62b6 (fix(test): change the role)
I double checked, I can repro this issue on any dashboard. The actions connected to those buttons work fine though

Yeah, that one i am not sure what can cause the behaviour difference as i can't reproduce it.

I appreciate the detailed review and testing. Thanks!

[kgabryje]

Thanks for checking @msyavuz and thank you for this HUGE pull request! That's really impressive amount of work and some nice refactors too 😄
@rusackas @eschutho @sadpandajoe @betodealmeida Could one of you take a look at this PR as well? We need a stamp from a code owner

[kgabryje]

@msyavuz I think I fixed this flaky DatabaseModal test in PR #30903 which I just merged. Could you rebase onto master and we'll see if the CI passes?

[rusackas]

This is great! Thanks for all the hard work!