Skip to content

feat: make ephemeral env use supersetbot + deprecate build_docker.py - #30870

Merged
mistercrunch merged 20 commits into
masterfrom
fix_ephemerals
Nov 22, 2024
Merged

mistercrunch merged 20 commits into
masterfrom
fix_ephemerals

Conversation

@mistercrunch

@mistercrunch mistercrunch commented Nov 7, 2024 •

Copy link
Copy Markdown
Member

Someone reported that ephemeral env builds are failing. Example action run here https://github.com/apache/superset/actions/runs/11721810688/job/32650049015#step:7:1219

The issue above seems to be a glitch/one-time-occurence, yet this PR is still relevant.

In this PR:

  • allow the ephemeral-env workflow to be testable using workflow_dispatch
  • aligns docker build to use supersetbot like the main docker-related workflows
  • removes now obsolete python script build_docker, replaced by supersetbot docker now, along with references in the docs

test command ->

gh workflow run ephemeral-env.yml --ref fix_ephemerals --field comment_body="/testenv up" --field issue_number=30870

@github-actions github-actions Bot added the github_actions Pull requests that update GitHub Actions code label Nov 7, 2024
@michael-s-molina michael-s-molina added review:draft review:checkpoint Last PR reviewed during the daily review standup labels Nov 7, 2024
@mistercrunch

Copy link
Copy Markdown
Member Author

/testenv up

@github-actions

github-actions Bot commented Nov 7, 2024

Copy link
Copy Markdown
Contributor

@mistercrunch Ephemeral environment spinning up at http://34.220.122.153:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@mistercrunch

Copy link
Copy Markdown
Member Author

Just a note that the test above operated from the main branch, since the changes are on the GHA workflow itself.

@pull-request-size pull-request-size Bot added size/L and removed size/S labels Nov 8, 2024
@mistercrunch
mistercrunch force-pushed the fix_ephemerals branch 5 times, most recently from 892690b to d40fd04 Compare November 8, 2024 01:27
@mistercrunch

Copy link
Copy Markdown
Member Author

BTW wasn't able to reproduce the issue, but this PR makes it easier to debug and aligns with using supersetbot to generate the docker command

@pull-request-size pull-request-size Bot added size/XL and removed size/L labels Nov 8, 2024
@github-actions github-actions Bot added the doc Namespace | Anything related to documentation label Nov 8, 2024
@sadpandajoe sadpandajoe removed the review:checkpoint Last PR reviewed during the daily review standup label Nov 8, 2024
@mistercrunch
mistercrunch marked this pull request as ready for review November 8, 2024 20:02
@mistercrunch

Copy link
Copy Markdown
Member Author

@github-actions

Copy link
Copy Markdown
Contributor

@ Ephemeral environment spinning up at http://54.202.175.138:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@mistercrunch

Copy link
Copy Markdown
Member Author

worked! Looks like there's some unrelated CI errors also seen on master

@mistercrunch
mistercrunch merged commit e0deb70 into master Nov 22, 2024
@mistercrunch
mistercrunch deleted the fix_ephemerals branch November 22, 2024 22:19
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 5.0.0 First shipped in 5.0.0 labels Jul 29, 2025
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels doc Namespace | Anything related to documentation github_actions Pull requests that update GitHub Actions code packages preset-io size/XXL 🚢 5.0.0 First shipped in 5.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants