fix: fixed Add Metrics to Tree Chart (#29158) by SBIN2010 · Pull Request #30679 · apache/superset

SBIN2010 · 2024-10-22T20:25:54Z

SUMMARY

Fixed add metrics in the tree chart page

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before:

after:

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue: Fixes Cannot Add Metrics to Tree Chart #29158
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

This reverts commit 35aaeb6.

SBIN2010 · 2025-03-18T20:33:29Z

/korbit-review

korbit-ai

I've completed my review and didn't find any issues.

Files scanned

File Path	Reviewed
superset-frontend/plugins/plugin-chart-echarts/src/Tree/controlPanel.tsx	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.

You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.

Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.

On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.

Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

Check out our docs on how you can make Korbit work best for you and your team.

Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

Setting Value

Review Schedule Automatic excluding drafts

Max Issue Count 10

Automatic PR Descriptions ❌

Issue Categories

Category Enabled

Documentation ✅

Logging ✅

Error Handling ✅

Readability ✅

Design ✅

Performance ✅

Security ✅

Functionality ✅

Feedback and Support

Tell us what you think of Korbit

Schedule a call with our team

Email us @ support@korbit.ai

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

rusackas · 2025-03-19T15:12:56Z

Running CI 🤞

SBIN2010 · 2025-04-02T10:08:51Z

hi @rusackas , is there anything else you need from me before this can be merged?

rusackas

LGTM! Thanks for the fix, AND for the patience!

(cherry picked from commit f5d6417)

* fix(sqllab): Missing allowHTML props in ResultTableExtension (apache#31960) * chore: replace selenium user with fixed user (apache#31844) * chore: Empty state refactor (apache#31860) * chore: fix `tsc` errors (apache#31965) Signed-off-by: hainenber <dotronghai96@gmail.com> * fix: proper URL building (apache#31962) * chore(build): enforce eslint rule banning antd imports outside of core Superset components (apache#31963) Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com> * fix(verbose map): Correct raw metrics handling in verbose map (apache#29417) * chore(deps): bump react-transition-group and @types/react-transition-group in /superset-frontend (apache#31547) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: refactor Alert-related components (apache#31858) * refactor: Removes the legacy dataset editor (apache#31976) * chore: Add FYND to INTHEWILD.md (apache#31980) * refactor(Shared_url_query): Fix shared query URL access for SQL Lab users. (apache#31421) * feat: run prettier before eslint in pre-commit hooks (apache#31984) * refactor: Remove CSV upload size limit and related validation (apache#32000) * chore(fe): correct typing for sheetsColumnNames (apache#32007) Signed-off-by: hainenber <dotronghai96@gmail.com> * refactor: upload data unification, less permissions and less endpoints (apache#31959) * fix(sqllab): tab layout truncated (apache#32005) * refactor: Upgrade to React 17 (apache#31961) * chore: add UPDATING note for CSV_UPLOAD_MAX_SIZE removal (apache#32013) * chore: Removing DASHBOARD_CROSS_FILTERS flag and all that comes with it. (apache#31794) Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> * feat: add date format to the email subject (apache#31413) Co-authored-by: Steven Liu <steven.l@covergenius.com> * chore(Network Errors): Update network errors on filter bars and charts (apache#31811) Co-authored-by: Geido <60598000+geido@users.noreply.github.com> * fix: Reordering echart props to fix confidence interval in Mixed Charts (apache#30716) Co-authored-by: Vedant Prajapati <40185967+vedantprajapati@users.noreply.github.com> * fix(issue apache#31927): TimeGrain.WEEK_STARTING_MONDAY (apache#32015) * feat(fe): upgrade `superset-frontend` to Typescript v5 (apache#31979) Signed-off-by: hainenber <dotronghai96@gmail.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * fix: Filters badge disappeared (apache#32025) * fix(ci): change ephemeral env to use github labels instead of comments (apache#31340) * fix: eph env + improve docker images to run in userspace (apache#32017) * fix: re-enable cypress checks (apache#32008) * fix: Revert "fix: re-enable cypress checks" (apache#32045) * fix(fe/explore): prevent runtime error when editing Dataset-origin Chart with empty title (apache#32031) Signed-off-by: hainenber <dotronghai96@gmail.com> * chore: Skip the creation of secondary perms during catalog migrations (apache#32043) * feat(sqllab): Replace FilterableTable by AgGrid Table (apache#29900) * chore: Add more database-related tests (follow up to apache#31948) (apache#32054) * fix(DatePicker): Increase z-index over Modal (apache#32061) * refactor(Radio): Upgrade Radio Component to Ant Design 5 (apache#32004) * chore: Re-enable asnyc event API tests (apache#32062) * feat(sqllab): improve table metadata UI (apache#32051) * fix(thumbnail cache): Enabling force parameter on screenshot/thumbnail cache (apache#31757) Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> * fix: enforce `ALERT_REPORTS_MAX_CUSTOM_SCREENSHOT_WIDTH` (apache#32053) * feat: add connector for Parseable (apache#32052) * fix: Histogram examples config (apache#32122) * fix(datepicker): Full width datepicker on filter value select (apache#32064) (cherry picked from commit cde2d49) * fix(ci): ephemeral env, handle different label, create comment (apache#32040) (cherry picked from commit 0cd0fcd) * fix: No virtual environment when running Docker translation compiler (apache#32133) (cherry picked from commit 53d944d) * chore: Adds RC1 data to CHANGELOG.md and UPDATING.md * chore(timeseries charts): adjust legend width by padding (apache#32030) (cherry picked from commit 8984f88) * fix: Local tarball Docker container is missing zstd dependency (apache#32135) (cherry picked from commit c64018d) * fix: move oauth2 capture to `get_sqla_engine` (apache#32137) (cherry picked from commit c7c3b1b) * fix(releasing): fix borked SVN-based image building process (apache#32151) Signed-off-by: hainenber <dotronghai96@gmail.com> (cherry picked from commit ea5879b) * fix(migrations): Handle no params in time comparison migration (apache#32155) (cherry picked from commit 6ed9dae) * fix: ScreenshotCachePayload serialization (apache#32156) (cherry picked from commit e8990f4) * fix(docker): Docker python-translation-build (apache#32163) (cherry picked from commit 5a8488a) * fix(virtual dataset sync): Sync virtual dataset columns when changing the SQL query (apache#30903) Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> (cherry picked from commit f3e7c64) * fix(sqllab): correct URL format for SQL Lab permalinks (apache#32154) (cherry picked from commit f9f8c5d) * fix: Adds an entry to UPDATING.md about DISABLE_LEGACY_DATASOURCE_EDITOR (apache#32185) * fix: TDengine move tdengine.png to databases/ subfolder (apache#32176) (cherry picked from commit 06f8f8e) * fix: handlebars html and css templates reset on dataset update (apache#32195) (cherry picked from commit 0f6bd5e) * fix: hidrate datasetsStatus (apache#32211) (cherry picked from commit eec54af) * fix(SaveDatasetModal): repairs field alignment in the SaveDatasetModal component (apache#32222) Co-authored-by: Geido <60598000+geido@users.noreply.github.com> (cherry picked from commit 650fa5c) * fix: set `Rich tooltip` -> 'Show percentage' to false by default (apache#32212) (cherry picked from commit d3b854a) * fix(sqllab): close the table tab (apache#32224) (cherry picked from commit 937d40c) * fix(Scope): Correct issue where filters appear out of scope when sort is unchecked. (apache#32115) (cherry picked from commit af3589f) * chore(ci): fix ephemeral env null issue number (apache#32220) (cherry picked from commit 60424c4) * chore(ci): fix ephemeral env null issue number (v2) (apache#32221) (cherry picked from commit 31d6f5a) * fix: Update 'Last modified' time when modifying RLS rules (apache#32227) Co-authored-by: Fardin Mustaque <fardinmustaque@Fardins-Mac-mini.local> (cherry picked from commit 52563d3) * docs: adding notes about using uv instead of raw pip (apache#32239) * fix: remove sort values on stacked totals (apache#31333) (cherry picked from commit 15fbb19) * fix: upgrade to 3.11.11-slim-bookworm to address critical vulnerabilities (apache#32240) (cherry picked from commit ad05732) * fix(Datasource): handle undefined datasource_type in fetchSyncedColumns (apache#32218) Co-authored-by: Erkka Tahvanainen <erkka.tahvanainen@confidently.fi> (cherry picked from commit 9da3095) * fix: Decimal values for Histogram bins (apache#32253) (cherry picked from commit ffe9244) * fix(viz/table): selected column not shown in Conditional Formatting popover (apache#32272) Signed-off-by: hainenber <dotronghai96@gmail.com> (cherry picked from commit dcc9628) * fix: keep the tab order (apache#30888) Co-authored-by: Steven Liu <steven.l@covergenius.com> (cherry picked from commit d5a5bd4) * fix: Download as PDF fails due to cache error (apache#32332) (cherry picked from commit 42a3c52) * fix: oauth2 trino (apache#31993) (cherry picked from commit 7ce1a34) * fix: revert "fix: remove sort values on stacked totals (apache#31333)" (apache#32337) (cherry picked from commit 422a07b) * fix(fe/dashboard-list): display modifier info for `Last modified` data (apache#32035) Signed-off-by: hainenber <dotronghai96@gmail.com> (cherry picked from commit 88cf2d5) * fix(roles): Add SqlLabPermalinkRestApi as default sqlab roles. (apache#32284) (cherry picked from commit 2c37ddb) * fix(SSHTunnelForm): make the password tooltip visible (apache#32356) (cherry picked from commit 4c4b5e8) * fix(firebolt): allow backslach escape for single quotes (apache#32350) (cherry picked from commit 22fe985) * fix(docker): Configure nginx for consistent port mapping and hot reloading (apache#32362) (cherry picked from commit 0f07d78) * fix: clickhouse-connect engine SSH parameter (apache#32348) (cherry picked from commit 8dcae81) * fix: ensure metric_macro expands templates (apache#32344) * fix: bump FAB to 4.5.4 (apache#32325) (cherry picked from commit c02a0a0) * fix(pinot): revert join and subquery flags (apache#32382) (cherry picked from commit 822d72c) * fix(viz): update nesting logic to handle multiple dimensions in PartitionViz (apache#32290) (cherry picked from commit 6317a91) * fix(clickhouse): get_parameters_from_uri failing when secure is true (apache#32423) (cherry picked from commit 84b52b2) * fix(com/grid-comp/markdown): pin `remark-gfm` to v3 to allow inline code block by backticks in Markdown (apache#32420) Signed-off-by: hainenber <dotronghai96@gmail.com> * fix(plugin-chart-echarts): remove erroneous upper bound value (apache#32473) (cherry picked from commit 5766c36) * fix(tooltip): displaying <a> tags correctly (apache#32488) (cherry picked from commit 6c3886a) * fix: skip DB filter when doing OAuth2 (apache#32486) (cherry picked from commit 813e79f) * fix: dashboard, chart and dataset import validation (apache#32500) (cherry picked from commit fc844d3) * fix(explore): Glitch in a tooltip with metric's name (apache#32499) (cherry picked from commit b3dfd49) * fix(beat): prune_query celery task args fix (apache#32511) (cherry picked from commit e98194c) * fix(Slack): Fix Slack recipients migration to V2 (apache#32336) (cherry picked from commit d2e0e2b) * fix: Show response message as default error (apache#32507) (cherry picked from commit c2de749) * fix: keep calculated columns when datasource is updated (apache#32523) (cherry picked from commit 99238dc) * fix(migrations): Handle comparator None in old time comparison migration (apache#32538) (cherry picked from commit 20e5df5) * fix(sqllab): Allow clear on schema and catalog (apache#32515) (cherry picked from commit 4c3aae7) * fix: add DateOffset to json serializer (apache#32532) * fix: Log table retention policy (apache#32572) (cherry picked from commit 89b6d7f) * fix(Slack V2): Specify the filename for the Slack upload method (apache#32599) (cherry picked from commit 8e021b0) * fix(dashboard): Support bigint value in native filters (apache#32549) (cherry picked from commit e7721a8) * fix(welcome): perf on distinct recent activities (apache#32608) (cherry picked from commit 832e028) * fix: Upgrade node base image to Debian 12 bookworm (apache#32652) (cherry picked from commit 2f6f5c6) * fix(dashboard): Ensure `dashboardId` is included in `form_data` for embedded mode (apache#32646) (cherry picked from commit 777760b) * fix(import): Import a DB connection with expanded rows enabled (apache#32657) (cherry picked from commit 0c6d868) * fix(gsheets): update params from encrypted extra (apache#32661) * fix: Update RELEASING/README.md (apache#32678) (cherry picked from commit b4dd64a) * fix(log): Update recent_activity by event name (apache#32681) (cherry picked from commit 449f51a) * fix: Signature of Celery pruner jobs (apache#32699) (cherry picked from commit df06bdf) * fix(cosmetics): allow toast message to be toggled off when modal is opened (apache#32691) Signed-off-by: hainenber <dotronghai96@gmail.com> (cherry picked from commit f1a222d) * fix(spreadsheet uploads): make file extension comparisons case-insensitive (apache#32696) (cherry picked from commit 6a13ab8) * fix: boolean filters in Explore (apache#32701) (cherry picked from commit 41bf215) * fix(logging): missing path in event data (apache#32708) (cherry picked from commit cd5a943) * fix: coerce datetime conversion errors (apache#32683) * fix(import): Ensure import exceptions are logged (apache#32410) (cherry picked from commit bc3e19d) * fix: ensure datasource permission in explore (apache#32679) (cherry picked from commit 9e30529) * fix(contextmenu): uncaught TypeError (apache#28203) (cherry picked from commit 29b62f7) * fix: Changing language doesn't affect echarts charts (apache#31751) Co-authored-by: Giampaolo Capelli <giampaolo.capelli@docaposte.fr> (cherry picked from commit 78efb62) * fix: do not add calculated columns when syncing (apache#32761) (cherry picked from commit 89ce7ba) * fix(chart control): Change default of "Y Axis Title Margin" (apache#32720) (cherry picked from commit d319543) * fix(sqllab): Pass query_id as kwarg so backoff can see it (apache#32774) (cherry picked from commit 01801e3) * fix(import): Missing catalog field in saved query schema (apache#32775) Co-authored-by: Vladislav Koren'kov <korenkov.vv@dns-shop.ru> (cherry picked from commit 5866f3e) * fix(css): typos in styles (apache#28350) (cherry picked from commit 5ec710e) * fix(config): correct slack image url in talisman (apache#32778) (cherry picked from commit 9bb3a57) * fix(excel export): big number truncation handling (apache#32739) (cherry picked from commit c0f83a7) * fix(model/helper): represent RLS filter clause in proper textual SQL string (apache#32406) Signed-off-by: hainenber <dotronghai96@gmail.com> (cherry picked from commit ff0529c) * fix(sec): resolve CVE-2025-29907 and CVE-2025-25977 by pinning `jspdf` to v3 (apache#32802) Signed-off-by: hainenber <dotronghai96@gmail.com> * fix: CSV/Excel upload form change column dates description (apache#32797) * fix: key error in frontend on disallowed GSheets (apache#32792) (cherry picked from commit 6f69c84) * fix: Time Comparison Feature Reverts Metric Labels to Metric Keys in Table Charts (apache#32665) Co-authored-by: Fardin Mustaque <fardinmustaque@Fardins-Mac-mini.local> (cherry picked from commit 7d77dc4) * fix(log): store navigation path to get correct logging path (apache#32795) (cherry picked from commit 4a70065) * fix(echarts): Sort series by name using naturalCompare (apache#32850) (cherry picked from commit 5222f94) * fix: update dataset/query catalog on DB changes (apache#32829) * fix(translation): Dutch translations for Current datetime filter (apache#31869) (cherry picked from commit 6c7f089) * fix(table-chart): Do not show comparison columns config if time_compare is set to [] (apache#32863) (cherry picked from commit f0dc1e7) * fix(ColorPickerControl): change color picker control width (apache#32851) (cherry picked from commit 37f626f) * fix: use role_model from security manager (apache#32873) (cherry picked from commit 103feda) * fix(backend/async_events): allow user to configure username for Redis authentication in GLOBAL_ASYNC_QUERIES_CACHE_BACKEND (apache#32372) Signed-off-by: hainenber <dotronghai96@gmail.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> (cherry picked from commit e0ed652) * fix(Jinja): Emit time grain to table charts even if they don't have a temporal column (apache#32871) (cherry picked from commit ab22bb1) * fix(sqllab): Invalid display of table column keys (apache#32763) (cherry picked from commit 56bf17f) * chore: Adds RC2 data to CHANGELOG.md * chore(🦾): bump python sqlglot 26.1.3 -> 26.11.1 (apache#32745) Co-authored-by: GitHub Action <action@github.com> (cherry picked from commit 66c1a6a) * fix: Clicking in the body of a Markdown component does not put it into edit mode (apache#32384) (cherry picked from commit 26743df) * fix(pivot-table): Revert "fix(Pivot Table): Fix column width to respect currency config (apache#31414)" (apache#32968) (cherry picked from commit a36e636) * fix: fixed Add Metrics to Tree Chart (apache#29158) (apache#30679) (cherry picked from commit f5d6417) * fix: Bar Chart (legacy) migration to keep labels layout (apache#32965) (cherry picked from commit 24b1666) * fix: `show_filters` URL parameter is not working (apache#29422) Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Vitor Avila <vitor.avila@preset.io> (cherry picked from commit bcb4332) * fix(dashboard): chart fullscreen issue when filter pane is collapsed (apache#28428) (cherry picked from commit 629b137) * fix: fix bug where dashboard did not enter fullscreen mode. (apache#32839) * fix(log): Missing failed query log on async queries (apache#33024) (cherry picked from commit 9b15e04) * fix(export): charts csv export in dashboards (apache#31720) (cherry picked from commit 6b7394e) * fix: improve error type on parse error (apache#33048) (cherry picked from commit ed0cd5e) * fix: Adds missing __init__ file to commands/logs (apache#33059) (cherry picked from commit c1159c5) * fix(docker): fallback to pip if uv is not available (apache#33087) (cherry picked from commit 164a07e) * fix(dashboard): Generate screenshot via celery (apache#32193) Co-authored-by: Erkka Tahvanainen <erkka.tahvanainen@confidently.fi> (cherry picked from commit 5656d69) * fix(thumbnails): ensure consistent cache_key (apache#33109) (cherry picked from commit 347c174) * fix: Allows configuration of Selenium Webdriver binary (apache#33103) (cherry picked from commit e1f5c49) * fix: resolve recent merge collisio (apache#33110) * fix: Bump FAB to 4.5.5 * fix(playwright): allow screenshotting empty dashboards (apache#33107) (cherry picked from commit 2233c02) * fix: Viz migration error handling (apache#33037) (cherry picked from commit bc0ffe0) * fix(dashboard): invalid active tab state (apache#33106) (cherry picked from commit 342e6f3) * fix(lang): patch FAB's LocaleView to redirect to previous page (apache#31692) * fix(echart): Tooltip date format doesn't follow time grain (apache#33138) (cherry picked from commit 7333ffd) * fix(echart): Thrown errors shown after resized (apache#33143) (cherry picked from commit 172e5dd) * fix: os.makedirs race condition (apache#33161) (cherry picked from commit 00f1fdb) * fix(deckgl): Update Arc to properly adjust line width (apache#33154) (cherry picked from commit b589d44) * fix(sqllab): Invalid SQL Error breaks SQL Lab (apache#33164) * fix(export): Full CSV/Excel exports respecting SQL_MAX_ROW config (apache#33214) (cherry picked from commit f7b7aac) * fix(antd): Invalid dashed border in tertiary button (apache#33291) * fix(standalone): Ensure correct URL param value for standalone mode (apache#33234) * fix(sqllab permalink): Commit SQL Lab permalinks (apache#33237) (cherry picked from commit fbd8ae2) * fix(heatmap): correctly render int and boolean falsy values on axes (apache#33238) (cherry picked from commit ac636c7) * fix(DB update): Gracefully handle querry error during DB update (apache#33250) (cherry picked from commit de84a53) * fix(histogram): remove extra single quotes (apache#33248) (cherry picked from commit d2360b5) * fix: LocalProxy is not mapped warning (apache#33025) (cherry picked from commit c029b53) * fix: mask password on DB import (apache#33267) * fix(echarts): rename time series shifted colnames (apache#33269) (cherry picked from commit ef14b52) * fix: improve function detection (apache#33306) (cherry picked from commit 339ba96) * fix: Temporal filter conversion in viz migrations (apache#33224) (cherry picked from commit 6db3a4d) * fix: Edge case with metric not getting quoted in sort by when normalize_columns is enabled (apache#33337) (cherry picked from commit 9f0ae77) * chore(🦾): bump python h11 0.14.0 -> 0.16.0 (apache#33339) Co-authored-by: GitHub Action <action@github.com> (cherry picked from commit 8252686) * fix(i18n): zh_TW pybabel compile error: placeholders are incompatible (apache#33345) * fix(be/utils): sync cache timeout for memoized function (apache#31917) Signed-off-by: hainenber <dotronghai96@gmail.com> (cherry picked from commit 4ed05f4) * fix: loading examples from raw.githubusercontent.com fails with 429 errors (apache#33354) (cherry picked from commit f045a73) * fix(Row): don't unload charts while embedded to reduce rerenders (apache#33422) (cherry picked from commit 21ca26a) * fix(deckgl): fix deckgl multiple layers chart filter and viewport (apache#33364) (cherry picked from commit 29ac507) * fix(table-chart): time shift is not working (apache#33425) (cherry picked from commit dc44748) * fix: allow metadata to parse json (apache#33444) (cherry picked from commit b050897) * fix(Sqllab): Autocomplete got stuck in UI when open it too fast (apache#33522) (cherry picked from commit b4e2406) * fix(table): table sort by fix (apache#33540) Co-authored-by: Amaan Nawab <nelsondrew07@gmail.com> Co-authored-by: Geido <60598000+geido@users.noreply.github.com> * fix(user settings): Update forked cosmo theme to resolve down chevron in caret style (apache#30514) (apache#30577) Co-authored-by: garriscp <garriscp@gmail.com> (cherry picked from commit b7d3ff1) * fix(AllEntities): Display action buttons according to the user permissions (apache#33553) (cherry picked from commit 546945e) * fix(sankey): incorrect nodeValues (apache#33431) Co-authored-by: richardfn <richard.fogaca@appsilon.com> (cherry picked from commit 38868f9) * fix: Adjust viz migrations to also migrate the queries object (apache#33285) Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> (cherry picked from commit 57183da) * fix: Missing processor context when rendering Jinja (apache#33596) (cherry picked from commit ce97597) * fix: Makes time compare migration more resilient (apache#33592) (cherry picked from commit b7ba500) * chore: Adds RC3 data to CHANGELOG.md * chore: update Dockerfile - Upgrade to 3.11.12 (apache#33612) (cherry picked from commit f0b6e87) * fix: Migrate charts with empty query_context (apache#33710) (cherry picked from commit 08655a7) * feat(api): Added uuid to list api calls (apache#32414) (cherry picked from commit 8decc9e) * fix(template_processing): get_filters now works for IS_NULL and IS_NOT_NULL operators (apache#33296) (cherry picked from commit cc34608) * fix(dashboard): show dashboard thumbnail images when retrieved (apache#33726) * fix(Alerts & reports): invalid "Last updated" time formatting (apache#33719) (cherry picked from commit 3ef92e5) * fix(explore): add gap to the "Cached" button (apache#33717) * fix(dataset): Fix plural toast messages (apache#33743) (cherry picked from commit a64b9ac) * fix: sync dot color between dashboard chart and edit chart (apache#33748) (cherry picked from commit 78ad6db) * fix(create chart page): add missing space between words (apache#33752) * fix: apply d3 format to BigNumber(s) (apache#33759) (cherry picked from commit d7d7b7c) * fix(tooltip): Sanitize tooltip html (apache#33765) (cherry picked from commit 8fd0fd6) * build: update Dockerfile to 3.11.13-slim-bookworm (apache#33745) (cherry picked from commit 7b6885a) * fix(Echarts): Echarts Legend Scroll fix (apache#33779) Co-authored-by: Amaan Nawab <nelsondrew07@gmail.com> * fix: SQL Lab warning message sizes (apache#33817) (cherry picked from commit 775a702) * chore: Adds RC4 data to CHANGELOG.md * chore: pin Marshmallow < 4 (apache#33978) * fix: Annotation layer errors (apache#34074) (cherry picked from commit d6ed819) * fix(explore): Display missing dataset for denied access (apache#34129) (cherry picked from commit 96cb603) * fix: Matching errorType on superset api error with SupersetError (apache#34261) (cherry picked from commit 229d925) * fix: Bulk select is not respecting the TAGGING_SYSTEM feature flag (apache#34282) (cherry picked from commit 1132460) * fix: Saved queries list break if one query can't be parsed (apache#34289) (cherry picked from commit 1e5a4e9) * fix: Update spacing on echart legends (apache#34018) (cherry picked from commit cb6342f) * fix: extract tables from jinja (apache#34307) * fix: Charts list is displaying empty dataset names when there's no schema (apache#34315) (cherry picked from commit 5f11f90) * fix(dataset): prevent metric duplication error when editing SQL and adding metric (apache#33523) Co-authored-by: QinQin <qinqin@geotab.com> (cherry picked from commit 2fba789) * fix(sqllab): access legacy kv record (apache#34411) (cherry picked from commit 762a11b) * fix: Users can't skip column sync when saving virtual datasets (apache#34509) * fix(echart): initial chart animation (apache#34516) (cherry picked from commit 1a7a381) * fix(native filters): throws an error when a chart containing a bigint value (apache#34539) (cherry picked from commit 2f8939d) * chore(explore): Add format sql and view in SQL Lab option in View Query (apache#33341) (cherry picked from commit 3a39840) * fix(table chart): render bigint value in a raw mode (apache#34556) (cherry picked from commit 8700a0b) * fix(echarts): rename time series shifted without dimensions (apache#34541) (cherry picked from commit 6f5d9c9) * fix: navigate to SQL Lab due to router api updates (apache#34569) (cherry picked from commit 53e9cf6) * fix(echart): broken aggregator due to bigint value (apache#34580) (cherry picked from commit 3e12d97) * chore(saved_query): Copy link to clipboard before redirect to edit (apache#34567) * fix: Timeseries annotation layers (apache#34709) (cherry picked from commit fc95c4f) * feat(file uploads): List only allowed schemas in the file uploads dialog (apache#32702) (cherry picked from commit e35145c) * fix: customize column description limit size in db_engine_spec (apache#34808) (cherry picked from commit 75af53d) * fix: User-provided Jinja template parameters causing SQL parsing errors (apache#34802) (cherry picked from commit e1234b2) * test * init - fix for exec-job 1 * create legacy security route * Fix runners errors found NGLS (#34) * Fix ruff erros * Fix ruff error * add mock to test_import_database_no_creds * Fix ruff error * Add favicon Atos * NGLS-4333: PDF for charts (#35) * Add pdf export functionality for charts * Add download charts from dashboards page * Improve export to charts and add unit tests * Update test * Fix build issue * Potential fix for pull request finding 'CodeQL / Incomplete multi-character sanitization' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> --------- Signed-off-by: hainenber <dotronghai96@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: JUST.in DO IT <justin.park@airbnb.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com> Co-authored-by: Đỗ Trọng Hải <41283691+hainenber@users.noreply.github.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: mcdogg17 <63260972+mcdogg17@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Darpan Jain <86348673+darpanjain07@users.noreply.github.com> Co-authored-by: Levis Mbote <111055098+LevisNgigi@users.noreply.github.com> Co-authored-by: sha174n <105581038+sha174n@users.noreply.github.com> Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Steven Liu <wzus579@gmail.com> Co-authored-by: Steven Liu <steven.l@covergenius.com> Co-authored-by: Mehmet Salih Yavuz <salih.yavuz@proton.me> Co-authored-by: Geido <60598000+geido@users.noreply.github.com> Co-authored-by: geotab-data-platform <93609609+geotab-data-platform@users.noreply.github.com> Co-authored-by: Vedant Prajapati <40185967+vedantprajapati@users.noreply.github.com> Co-authored-by: Adrian Mastronardi <7809331+AdrianMastronardi@users.noreply.github.com> Co-authored-by: Vitor Avila <96086495+Vitor-Avila@users.noreply.github.com> Co-authored-by: Enzo Martellucci <52219496+EnxDev@users.noreply.github.com> Co-authored-by: Jack <41238731+fisjac@users.noreply.github.com> Co-authored-by: AdheipSingh <34169002+AdheipSingh@users.noreply.github.com> Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> Co-authored-by: Antonio Rivero <38889534+Antonio-RiveroMartnez@users.noreply.github.com> Co-authored-by: EmmanuelCbd <107679420+EmmanuelCbd@users.noreply.github.com> Co-authored-by: Alex Duan <51781608+DuanKuanJun@users.noreply.github.com> Co-authored-by: Damian Pendrak <dpendrak@gmail.com> Co-authored-by: Fardin Mustaque <105560328+fardin-developer@users.noreply.github.com> Co-authored-by: Fardin Mustaque <fardinmustaque@Fardins-Mac-mini.local> Co-authored-by: gpchandran <poorana@gmail.com> Co-authored-by: Erkka Tahvanainen <59445256+tahvane1@users.noreply.github.com> Co-authored-by: Erkka Tahvanainen <erkka.tahvanainen@confidently.fi> Co-authored-by: Dmitry Kochnev <aurokkez@gmail.com> Co-authored-by: Dino <108456389+maybedino@users.noreply.github.com> Co-authored-by: Yuri <yuri.bogomolov@robinhood.com> Co-authored-by: Le Xich Long <codenamelxl@users.noreply.github.com> Co-authored-by: Usiel Riedl <usiel.riedl@automattic.com> Co-authored-by: Dolph Mathews <dolph.mathews@gmail.com> Co-authored-by: Andrey Yakir <49098339+mostopalove@users.noreply.github.com> Co-authored-by: Sam Firke <sfirke@users.noreply.github.com> Co-authored-by: Paul Rhodes <withnale@users.noreply.github.com> Co-authored-by: Daniel Höxtermann <daniel@hxtm.dev> Co-authored-by: sowo <wolfgangsommerer@gmail.com> Co-authored-by: Giampaolo Capelli <giampaolo.capelli@gmail.com> Co-authored-by: Giampaolo Capelli <giampaolo.capelli@docaposte.fr> Co-authored-by: Vladislav Korenkov <73882772+Quatters@users.noreply.github.com> Co-authored-by: Vladislav Koren'kov <korenkov.vv@dns-shop.ru> Co-authored-by: Ruslan <108723249+Kukusik8@users.noreply.github.com> Co-authored-by: V9 Developer <99959044+v9dev@users.noreply.github.com> Co-authored-by: CharlesNkdl <100453363+CharlesNkdl@users.noreply.github.com> Co-authored-by: SBIN2010 <132096459+SBIN2010@users.noreply.github.com> Co-authored-by: Chris <144701341+chrisvnimbus@users.noreply.github.com> Co-authored-by: Christiaan Baartse <anotherhero@gmail.com> Co-authored-by: Luke Hart <50547373+lohart13@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: notHuman9504 <127070922+notHuman9504@users.noreply.github.com> Co-authored-by: Hex Café <157834442+hexcafe@users.noreply.github.com> Co-authored-by: Vitor Avila <vitor.avila@preset.io> Co-authored-by: Hugo Lavernhe <hugo.lavernhe@gmail.com> Co-authored-by: Hossein Khalilian <hse.khalilian08@gmail.com> Co-authored-by: Jillian <jill@opencraft.com> Co-authored-by: Jacob Amrany <jamra@users.noreply.github.com> Co-authored-by: Shao Yu-Lung (Allen) <bestlong168@gmail.com> Co-authored-by: Syed Bariman Jan <syedbarimanjan@gmail.com> Co-authored-by: Rafael Benitez <rebenitez1802@gmail.com> Co-authored-by: amaannawab923 <amaannawab923@gmail.com> Co-authored-by: Amaan Nawab <nelsondrew07@gmail.com> Co-authored-by: Mike Klumpenaar <mklumpen@gmail.com> Co-authored-by: garriscp <garriscp@gmail.com> Co-authored-by: Richard Fogaca Nienkotter <63572350+richardfogaca@users.noreply.github.com> Co-authored-by: richardfn <richard.fogaca@appsilon.com> Co-authored-by: Luiz Otavio <45200344+luizotavio32@users.noreply.github.com> Co-authored-by: Kasper Mol <awsumthx@gmail.com> Co-authored-by: Pat Buxton <45275736+rad-pat@users.noreply.github.com> Co-authored-by: Ananta Patil <77204384+anantaoutlook@users.noreply.github.com> Co-authored-by: Joe Li <joe@preset.io> Co-authored-by: jqqin <63757369+jqqin@users.noreply.github.com> Co-authored-by: QinQin <qinqin@geotab.com> Co-authored-by: Eduardo Sanday <eduardo.sanday.external@atos.net> Co-authored-by: Samuel Sales <samuel.sales@atos.net> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

fix: fixed Add Metrics to Tree Chart (apache#29158)

19151d1

pull-request-size Bot added the size/XS label Oct 22, 2024

github-actions Bot added the plugins label Oct 22, 2024

fix: clear modal after CSS templates is added

35aaeb6

SBIN2010 changed the title ~~fix: fixed Add Metrics to Tree Chart (#29158)~~ fix: fixed Add Metrics to Tree Chart (apache#29158) Oct 22, 2024

SBIN2010 changed the title ~~fix: fixed Add Metrics to Tree Chart (apache#29158)~~ fix: fixed Add Metrics to Tree Chart (#29158) Oct 22, 2024

michael-s-molina requested review from justinpark and kgabryje October 23, 2024 17:22

justinpark reviewed Oct 23, 2024

View reviewed changes

Comment thread superset-frontend/src/features/cssTemplates/CssTemplateModal.tsx Outdated

Revert "fix: clear modal after CSS templates is added"

db3afda

This reverts commit 35aaeb6.

SBIN2010 requested a review from justinpark October 30, 2024 06:36

SBIN2010 and others added 3 commits November 25, 2024 21:45

fix: tree metrics exclude validator

9eea2e6

Merge branch 'apache:master' into master

3930c95

Merge branch 'apache:master' into master

b355212

korbit-ai Bot reviewed Mar 18, 2025

View reviewed changes

SBIN2010 added 2 commits March 20, 2025 22:26

Merge branch 'apache:master' into master

7200d6c

Merge branch 'apache:master' into master

3049a3d

SBIN2010 added a commit to SBIN2010/MYsuperset that referenced this pull request Mar 25, 2025

fix: revert apache#30679

368789a

SBIN2010 added a commit to SBIN2010/MYsuperset that referenced this pull request Mar 25, 2025

fix: revert apache#30679

e9ba2c8

SBIN2010 added a commit to SBIN2010/MYsuperset that referenced this pull request Mar 26, 2025

fix: add [apache#30679]

18ea1e0

Merge branch 'apache:master' into master

247aef8

rusackas approved these changes Apr 2, 2025

View reviewed changes

rusackas merged commit f5d6417 into apache:master Apr 2, 2025

michael-s-molina added the v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch label Apr 3, 2025

michael-s-molina pushed a commit that referenced this pull request Apr 3, 2025

fix: fixed Add Metrics to Tree Chart (#29158) (#30679)

8229fd3

(cherry picked from commit f5d6417)

rusackas mentioned this pull request Apr 3, 2025

Cannot Add Metrics to Tree Chart #29158

Closed

2 of 3 tasks

michael-s-molina pushed a commit that referenced this pull request Apr 14, 2025

fix: fixed Add Metrics to Tree Chart (#29158) (#30679)

e756094

(cherry picked from commit f5d6417)

alexandrusoare pushed a commit to alexandrusoare/superset that referenced this pull request Jun 19, 2025

fix: fixed Add Metrics to Tree Chart (apache#29158) (apache#30679)

43cc3fe

(cherry picked from commit f5d6417)

SBIN2010 added a commit to SBIN2010/MYsuperset that referenced this pull request Jul 10, 2025

fix: revert apache#30679

601dde2

silveira-js mentioned this pull request Jan 7, 2026

Add MapLibre support to charts PortalTelemedicina/superset#4

Merged

9 tasks

This was referenced Jan 15, 2026

Point explicit service account to client PortalTelemedicina/superset#9

Merged

Fix margin parameters PortalTelemedicina/superset#10

Merged

silveira-js mentioned this pull request Jan 26, 2026

Adjust Styling Options PortalTelemedicina/superset#11

Closed

qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026

fix: fixed Add Metrics to Tree Chart (apache#29158) (apache#30679)

e83f0f1

Navigation Menu

fix: fixed Add Metrics to Tree Chart (#29158) - #30679

fix: fixed Add Metrics to Tree Chart (#29158)#30679
rusackas merged 9 commits into
apache:masterfrom
SBIN2010:master

SBIN2010 commented Oct 22, 2024 •

edited by rusackas

Loading

Uh oh!

Uh oh!

SBIN2010 commented Mar 18, 2025

Uh oh!

korbit-ai Bot left a comment •

edited

Loading

Uh oh!

rusackas commented Mar 19, 2025

Uh oh!

SBIN2010 commented Apr 2, 2025

Uh oh!

rusackas left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	❌

Category	Enabled
Documentation	✅
Logging	✅
Error Handling	✅
Readability	✅
Design	✅
Performance	✅
Security	✅
Functionality	✅

Conversation

SBIN2010 commented Oct 22, 2024 • edited by rusackas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

Uh oh!

SBIN2010 commented Mar 18, 2025

Uh oh!

korbit-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Interacting with Korbit

Customizing Korbit

Current Korbit Configuration

Feedback and Support

Looking to add Korbit to your team? Get started with a free 2 week trial here

Uh oh!

rusackas commented Mar 19, 2025

Uh oh!

SBIN2010 commented Apr 2, 2025

Uh oh!

rusackas left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SBIN2010 commented Oct 22, 2024 •

edited by rusackas

Loading

korbit-ai Bot left a comment •

edited

Loading