Repository navigation
fix: only show dataset name in list - #29944
Merged
Merged
Conversation
eschutho
changed the title
eschutho
force-pushed
the
elizabeth/fix-dataset-name
branch
from
August 15, 2024 00:05
5748c92 to
af6cd00
Compare
rusackas
approved these changes
Aug 15, 2024
rusackas
left a comment
rusackas
left a comment
Member
There was a problem hiding this comment.
LGTM. Doesn't seem like a breaking change since the info is still available.
Member
|
It may be misleading to not show the schema alongside the dataset name given that many datasets have the same name. I understand that users can still view this information in the tooltip, but I don't think it's sufficient. It also kind of force the user to hover the name to see if it's actually the dataset from a particular schema. Maybe add a column for schema? |
Member
|
There's no schema filter either. Maybe it would be good to add one, specially if we have a schema column. |
nyohasstium
pushed a commit
to Webgains/superset
that referenced
this pull request
Jan 2, 2025
9 tasks
mistercrunch
added
🏷️ bot
rusackas
added a commit
that referenced
this pull request
Aug 19, 2025
…ctly Fixes #33335 Virtual datasets with names that don't contain a period (no schema prefix) were not displaying correctly in the chart list. The issue was caused by PR #29944 which assumed all dataset names would have a schema.name format and split by '.' to extract just the name. This fix properly handles both formats: - schema.name (displays as "name") - name without schema (displays as "name") - Names containing dots are handled correctly by only removing the first segment (schema) Added comprehensive tests to verify the fix works for all dataset name formats. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Shows just the dataset name, as with the schema it tends to be too long. I moved the full schema/dataset name into the tooltip. The link remains the same.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2024-08-14.at.3.26.12.PM.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION