Repository navigation
Disable containerd for docker compose running in GHA - #140
Merged
Merged
Conversation
mrproliu
marked this pull request as draft
February 21, 2026 09:05
mrproliu
marked this pull request as ready for review
February 21, 2026 09:30
wu-sheng
approved these changes
Feb 21, 2026
kezhenxu94
added a commit
that referenced
this pull request
Apr 15, 2026
…146) * feat: migrate to testcontainers-go v0.42.0 and upgrade all major dependencies - Delete compose_provider.go (601 lines) — custom DockerContainer/DockerProvider re-implementation replaced by native testcontainers-go APIs - Delete compose_listener.go (85 lines) — Docker event listener no longer needed; containers are accessible after stack.Up() via stack.ServiceContainer() - Rewrite compose.go to use compose.NewDockerComposeWith + stack.Up/ServiceContainer - Rewrite cleanup/compose.go to use stack.Down - Upgrade testcontainers-go v0.11.1 → v0.42.0 - Upgrade docker/docker v20.10.7 → v28.5.2 - Upgrade k8s.io/* v0.22.2 → v0.35.3 - Upgrade sigs.k8s.io/kind v0.27.0 → v0.31.0 - Upgrade spf13/cobra v1.8.0 → v1.10.2 - Remove docker-compose v1 binary install from CI (v0.42.0 uses Docker Compose v2 plugin) - Update action.yaml Go version to 1.26 Closes #139 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: add multi-platform CI build matrix and CGO_ENABLED support Split Build workflow into lint-and-test + build-platform (ubuntu/windows/macos) matrix jobs. Enable CGO for native builds. Update Dockerfile with build-essential for CGO. Change `make build` to build for current OS only (CI matrix handles cross-platform). Based on #139 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: remove compose.Wait(true) to avoid requiring all containers healthy compose.Wait(true) maps to `docker compose up --wait` which requires ALL containers to remain running and healthy. This is too strict for e2e tests where some containers may not have healthchecks or may exit after init. Port readiness is already handled by WaitForService() with per-port wait strategies. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: remove containerd image store disable workaround No longer needed — testcontainers-go v0.42.0 uses Docker Compose v2 plugin which fully supports the containerd image store. Reverts the workaround added in 8c21e43 (#140). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: add manual port waiting after compose up WaitForService strategies only execute when compose.Wait(true) is passed, but compose.Wait(true) is too strict (requires all containers healthy). Instead, manually wait for each port via TCP dial after Up() returns, matching the old code's behavior of waitPortUntilReady(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: restore DOCKER_API_VERSION negotiation in action.yaml Docker SDK v28.5.2 defaults to API v1.51, but GitHub Actions runners may only support up to v1.48. Set DOCKER_API_VERSION to the daemon's supported version to ensure compatibility. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: add logging to port waiting and try immediately before polling Add INFO-level logs for port wait start/completion and DEBUG-level for retry attempts. Also try connecting immediately before the first ticker interval to avoid unnecessary 500ms delay when ports are already ready. Log when a service has no ports to wait for. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: wait for Docker healthcheck before port readiness check After stack.Up(), wait for each container's Docker healthcheck to pass (if defined) before doing TCP port checks. This matches the old behavior where docker-compose up -d would respect depends_on: condition: service_healthy. Also restored internal container port check (/proc/net/tcp + nc + /dev/tcp) from the old WaitPort implementation to align with original behavior. The wait sequence is now: 1. stack.Up(ctx) — start containers 2. waitForHealthy — poll Docker health status until healthy (if healthcheck defined) 3. waitForPort — external TCP dial + internal container check 4. Export env vars Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: only wait for healthcheck on services with ports The old code only waited for services that had ports: in docker-compose.yml. Services without ports were completely skipped. The healthcheck wait was incorrectly running on ALL services, causing timeouts on services like init containers or senders whose healthchecks depend on other services. Now: services without ports get log streaming only. Services with ports get healthcheck wait + port wait + env export (matching old behavior). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: remove healthcheck waiting, use only TCP+internal port check The old code never checked Docker healthcheck status. It only did TCP dial + internal /proc/net/tcp check. Many compose files use healthchecks with tools (nc) not available in the container image, causing Docker to mark containers as unhealthy even when the application is running fine. Remove waitForHealthy entirely to match old behavior exactly: port-level waiting only, no Docker healthcheck dependency. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: restore build target to build all platforms for release The build target must build all platforms (windows/linux/darwin) because release-bin depends on it. Each platform build uses CGO_FLAG to enable CGO only for native builds. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: build only current platform per CI matrix runner Each matrix runner (ubuntu/windows/macos) now builds only its own platform instead of all three redundantly. The `make build` target is preserved for release which needs all platforms. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * ci: simplify build matrix by moving OS-to-target mapping into matrix include --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: kezhenxu94 <kezhenxu94@apache.org>
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.