Skip to content

Fix CI on ubuntu-26.04 runners #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wu-sheng merged 4 commits into from
Oct 31, 2026
Merged

Fix CI on ubuntu-26.04 runners #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2872b7
Bump skywalking-infra-e2e off the containerd snapshotter workaround
wu-sheng Oct 31, 2026
1e04c87
Pin docker/login-action to an approved revision
wu-sheng Oct 31, 2026
f1e246a
Stop setting SW_QUERY_ZIPKIN twice in the E2E installs
wu-sheng Oct 31, 2026
3c442be
Raise the inotify limits for the kind E2E cluster
wu-sheng Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions .github/workflows/e2e.ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,17 +55,23 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Login to ghcr
uses: docker/login-action@af1e73f918a031802d376d3c8bbc3fe56130a9b0 # v4.4.0
uses: docker/login-action@81c6f93d4bc991e510b342a00b419b3bb4efc5c6 # v4.7.0
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Setup go
uses: actions/setup-go@v4
with:
go-version: '1.24'
# The kind nodes and all their pods share the host's inotify limits. Without this, BanyanDB
# standalone exits with "couldn't initialize inotify: too many open files". Raise them to at
# least the values the kind known-issues page recommends.
- name: Raise inotify limits for kind
run: |
watches=$(sysctl -n fs.inotify.max_user_watches)
instances=$(sysctl -n fs.inotify.max_user_instances)
echo "runner defaults: max_user_watches=${watches} max_user_instances=${instances}"
sudo sysctl -w fs.inotify.max_user_watches=$(( watches > 524288 ? watches : 524288 )) \
fs.inotify.max_user_instances=$(( instances > 512 ? instances : 512 ))
- name: ${{ matrix.test.name }}
uses: apache/skywalking-infra-e2e@8c21e43e241a32a54bdf8eeceb9099eb27e5e9b4
uses: apache/skywalking-infra-e2e@56ac8befeb5f910f2dc9339e65d07cd18953f90e
with:
e2e-file: $GITHUB_WORKSPACE/${{ matrix.test.config }}
- if: ${{ failure() }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-helm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ jobs:
test -f "skywalking-helm-${VERSION}.tgz" || { echo "::error::package did not produce skywalking-helm-${VERSION}.tgz"; exit 1; }

- name: Log in to the container registry
uses: docker/login-action@af1e73f918a031802d376d3c8bbc3fe56130a9b0 # v4.4.0
uses: docker/login-action@81c6f93d4bc991e510b342a00b419b3bb4efc5c6 # v4.7.0
with:
registry: ${{ env.DOCKER_REGISTRY }}
username: ${{ env.DOCKER_USERNAME }}
Expand Down
6 changes: 4 additions & 2 deletions docs/contributing/e2e-tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,10 @@ each of those pairings needs.
| `test/e2e/e2e-oap11-banyandb-cluster.yaml` | 11.0.0 | BanyanDB 0.11, cluster mode | As above but `banyandb.standalone.enabled=false`, `banyandb.cluster.enabled=true`. |

All three also switch Zipkin on — `oap.ports.zipkin-query=9412` plus `SW_RECEIVER_ZIPKIN=default`
and `SW_QUERY_ZIPKIN=default` — because the chart only emits `oap.zipkinUrl` into Horizon's config
when that port is set, and one verify case asserts Horizon can reach it. Each runs seven cases.
— because the chart only emits `oap.zipkinUrl` into Horizon's config when that port is set, and one
verify case asserts Horizon can reach it. The port already makes the chart set `SW_QUERY_ZIPKIN`;
setting it again through `oap.env` duplicates the env entry, which Helm 4's server-side apply
rejects. Each runs seven cases.

### The fourth cell: `e2e-config-override.yaml`

Expand Down
1 change: 0 additions & 1 deletion test/e2e/e2e-oap11-banyandb-cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ setup:
--set banyandb.auth.enabled=true \
--set oap.ports.zipkin-query=9412 \
--set oap.env.SW_RECEIVER_ZIPKIN=default \
--set oap.env.SW_QUERY_ZIPKIN=default \
--set satellite.enabled=true \
--set satellite.image.repository=$SATELLITE_REPO \
--set satellite.image.tag=$SATELLITE_TAG \
Expand Down
1 change: 0 additions & 1 deletion test/e2e/e2e-oap11-banyandb-standalone.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ setup:
--set banyandb.auth.enabled=true \
--set oap.ports.zipkin-query=9412 \
--set oap.env.SW_RECEIVER_ZIPKIN=default \
--set oap.env.SW_QUERY_ZIPKIN=default \
--set satellite.enabled=true \
--set satellite.image.repository=$SATELLITE_REPO \
--set satellite.image.tag=$SATELLITE_TAG \
Expand Down
1 change: 0 additions & 1 deletion test/e2e/e2e-oap11-elasticsearch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ setup:
--set oap.storageType=elasticsearch \
--set oap.ports.zipkin-query=9412 \
--set oap.env.SW_RECEIVER_ZIPKIN=default \
--set oap.env.SW_QUERY_ZIPKIN=default \
--set satellite.enabled=true \
--set satellite.image.repository=$SATELLITE_REPO \
--set satellite.image.tag=$SATELLITE_TAG \
Expand Down
Loading