fix: validate all Lite subscription topics - #10897
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10897 +/- ##
=============================================
- Coverage 48.41% 48.30% -0.12%
+ Complexity 13571 13531 -40
=============================================
Files 1380 1380
Lines 101165 101167 +2
Branches 13127 13128 +1
=============================================
- Hits 48981 48866 -115
- Misses 46220 46305 +85
- Partials 5964 5996 +32 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
This PR fixes a validation gap in Lite subscription topic checking. Previously, only the first subscription's topic was validated, meaning mismatched topics in non-first positions would silently pass. The fix iterates through all subscriptions to validate each one.
Verdict: LGTM — clean, minimal fix with proper test coverage using LinkedHashSet to ensure the mismatching entry isn't accidentally first.
Automated review by github-manager-bot
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Validates all Lite subscriptions against the bound topic, not just the first. Clean validation fix with test coverage.
LGTM.
Automated review by github-manager-bot
Summary
Closes #10895
Tests
mvn -pl proxy -Dtest=ClientProcessorTest test(JDK 8)