Skip to content

fix: validate all Lite subscription topics - #10897

Open
Aias00 wants to merge 1 commit into
apache:developfrom
Aias00:fix/lite-subscription-topic-validation
Open

fix: validate all Lite subscription topics#10897
Aias00 wants to merge 1 commit into
apache:developfrom
Aias00:fix/lite-subscription-topic-validation

Conversation

@Aias00

@Aias00 Aias00 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • validate every Lite subscription against the group bound topic
  • reject a subscription set when any entry targets a different topic

Closes #10895

Tests

  • mvn -pl proxy -Dtest=ClientProcessorTest test (JDK 8)

Copilot AI lite review requested due to automatic review settings August 10, 2026 04:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.30%. Comparing base (e345861) to head (24215e2).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10897      +/-   ##
=============================================
- Coverage      48.41%   48.30%   -0.12%     
+ Complexity     13571    13531      -40     
=============================================
  Files           1380     1380              
  Lines         101165   101167       +2     
  Branches       13127    13128       +1     
=============================================
- Hits           48981    48866     -115     
- Misses         46220    46305      +85     
- Partials        5964     5996      +32     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

This PR fixes a validation gap in Lite subscription topic checking. Previously, only the first subscription's topic was validated, meaning mismatched topics in non-first positions would silently pass. The fix iterates through all subscriptions to validate each one.

Verdict: LGTM — clean, minimal fix with proper test coverage using LinkedHashSet to ensure the mismatching entry isn't accidentally first.


Automated review by github-manager-bot

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Validates all Lite subscriptions against the bound topic, not just the first. Clean validation fix with test coverage.

LGTM.


Automated review by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Validate every Lite consumer subscription against its bound topic

4 participants