Repository navigation
docs: document plugin.xml V4 vs V3 - #13261
Conversation
gnodet-bot
left a comment
gnodet-bot
left a comment
There was a problem hiding this comment.
Docs backport is faithful and accurate. One minor nit in plugin.mdo.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
gnodet-bot
left a comment
gnodet-bot
left a comment
There was a problem hiding this comment.
Previous nit addressed — plugin.mdo now has the trailing newline. The rest of the backport is faithful: site.xml nav cleanup, .mdo description additions, and the index.md updates all match the source PR #13253 accurately. The lifecycle-mappings.html menu removal is consistent with the parent commit. Clean.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
5f3e0a3 to
b326659
Compare
Backport of apache#13253 to maven-3.10.x. Fills in previously empty descriptions for the following fields in maven-plugin-api/src/main/mdo/plugin.mdo: - goalPrefix, isolatedRealm, inheritedByDefault (PluginDescriptor) - executeLifecycle, composer, parameters (MojoDescriptor) - roleHint (Requirement)
b326659 to
7a05c5e
Compare
gnodet-bot
left a comment
gnodet-bot
left a comment
There was a problem hiding this comment.
Previous nit (trailing newline on plugin.mdo) has been addressed in this squash. All seven filled descriptions are accurate and consistent with the source PR #13253:
goalPrefix,isolatedRealm,inheritedByDefaultonPluginDescriptor✓executeLifecycle,composer,parametersonMojoDescriptor✓roleHintonRequirement✓
The three remaining empty <description> tags (configuration, and both implementation fields) are pre-existing on maven-3.10.x and outside this PR's stated scope — not a concern here.
Clean backport.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
2 participants
Backport of #13253 (4398d65) to
maven-3.10.x.Conflict resolution:
maven-plugin-api/src/main/mdo/plugin.mdo: descriptions from the commit applied, version tags kept at1.0.0(not1.0.0+), V4-onlyresolutionsfield discardedmaven-model-builder/src/site/markdown/super-pom.md.vm: restored (false conflict from git path mapping)compat/maven-plugin-api/src/main/mdo/plugin.mdo: removed (path does not exist on 3.10.x flat layout)