Skip to content

[MRESOLVER-292] Fix configuration name in documentation to match with actual name - #217

Merged
cstamas merged 1 commit into
apache:masterfrom
typo-fix:master
Nov 13, 2022
Merged

[MRESOLVER-292] Fix configuration name in documentation to match with actual name#217
cstamas merged 1 commit into
apache:masterfrom
typo-fix:master

Conversation

@caiwei-ebay

@caiwei-ebay caiwei-ebay commented Nov 10, 2022 •
edited by cstamas
Loading

Copy link
Copy Markdown
Contributor

As discussed in https://issues.apache.org/jira/browse/MNG-5896, the param in code does not match with the one in doc:
https://maven.apache.org/resolver/configuration.html

DOC: aether.dependencyCollector.impl
Code: aether.collector.impl

https://issues.apache.org/jira/browse/MRESOLVER-292

@caiwei-ebay

caiwei-ebay commented Nov 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@michael-o @cstamas

Please help check.

@cstamas cstamas added this to the 1.9.1 milestone Nov 11, 2022
@cstamas cstamas changed the title fix param does not match with doc [MRESOLVER-292] Fix configuration name in documentation to match with actual name Nov 11, 2022
@caiwei-ebay

caiwei-ebay commented Nov 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@cstamas

Thanks for the review.
Looks like 1.9.0 was not released successfully, would you please retry the 1.9.0 release or 1.9.0 will be skipped and 1.9.1 will be the next version? Just hoping people could try out and feedback with 1.9.0 at the earliest.

@cstamas

cstamas commented Nov 12, 2022

Copy link
Copy Markdown
Member

Thanks for the review. Looks like 1.9.0 was not released successfully, would you please retry the 1.9.0 release or 1.9.0 will be skipped and 1.9.1 will be the next version? Just hoping people could try out and feedback with 1.9.0 at the earliest.

What do you mean by "1.9.0 was not released successfully"? It is out there on Central, and even Maven PR now successfully use it? apache/maven#831

@cstamas

cstamas commented Nov 12, 2022

Copy link
Copy Markdown
Member

1.9.1 release is planned, so far 3 PRs https://github.com/apache/maven-resolver/milestone/1

@caiwei-ebay

caiwei-ebay commented Nov 13, 2022

Copy link
Copy Markdown
Contributor Author

@cstamas Saw the jars in Central and docs updated: https://maven.apache.org/resolver/configuration.html#. Thanks!

@cstamas
cstamas merged commit e1b5ab9 into apache:master Nov 13, 2022
@jira-importer

jira-importer commented Jun 13, 2025

Copy link
Copy Markdown

Resolve #966

3 similar comments
@jira-importer

jira-importer commented Jun 13, 2025

Copy link
Copy Markdown

Resolve #966

@jira-importer

jira-importer commented Jun 13, 2025

Copy link
Copy Markdown

Resolve #966

@jira-importer

jira-importer commented Jun 13, 2025

Copy link
Copy Markdown

Resolve #966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cstamas cstamas cstamas approved these changes
@michael-o michael-o michael-o approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.9.1

Development

Successfully merging this pull request may close these issues.

4 participants

@caiwei-ebay @cstamas @jira-importer @michael-o