Conversation
gnodet
left a comment
There was a problem hiding this comment.
LGTM — Clean, mechanical housekeeping change that replaces http:// with https:// in Apache License 2.0 URLs across 180 files. No functional code changes, only license header comments affected. CI is mostly green.
Two minor observations:
-
Issue reference: The PR body says "fixes #2051" (self-referencing). The actual issue is #2048 ("http → https in license"). Updating the body to "fixes #2048" would auto-close the correct issue on merge.
-
Incomplete coverage: ~838 files in the repo still contain
http://www.apache.org/licenses/LICENSE-2.0(including most ofmaven-resolver-util, many test files, etc.). This PR is valid as-is, but a follow-up would be needed to complete the migration. -
.git-blame-ignore-revs: Consider adding the merge commit SHA to.git-blame-ignore-revs(which already has a prior bulk-style commit entry) to keepgit blameuseful on these 180 files.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of gnodet
fixes #2048