Skip to content

Use https in license URLs as recommended by ASF - #2051

Merged
elharo merged 2 commits into
masterfrom
i2048
Aug 9, 2026
Merged

Use https in license URLs as recommended by ASF#2051
elharo merged 2 commits into
masterfrom
i2048

Conversation

@elharo

@elharo elharo commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

fixes #2048

@elharo
elharo requested a review from cstamas August 9, 2026 11:23
@elharo
elharo marked this pull request as ready for review August 9, 2026 11:25

@gnodet gnodet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — Clean, mechanical housekeeping change that replaces http:// with https:// in Apache License 2.0 URLs across 180 files. No functional code changes, only license header comments affected. CI is mostly green.

Two minor observations:

  1. Issue reference: The PR body says "fixes #2051" (self-referencing). The actual issue is #2048 ("http → https in license"). Updating the body to "fixes #2048" would auto-close the correct issue on merge.

  2. Incomplete coverage: ~838 files in the repo still contain http://www.apache.org/licenses/LICENSE-2.0 (including most of maven-resolver-util, many test files, etc.). This PR is valid as-is, but a follow-up would be needed to complete the migration.

  3. .git-blame-ignore-revs: Consider adding the merge commit SHA to .git-blame-ignore-revs (which already has a prior bulk-style commit entry) to keep git blame useful on these 180 files.

This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.

Claude Code on behalf of gnodet

@elharo
elharo merged commit d239787 into master Aug 9, 2026
23 of 24 checks passed
@elharo
elharo deleted the i2048 branch August 9, 2026 11:46
@github-actions github-actions Bot added this to the 2.0.22 milestone Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

http --> https in license

2 participants