Conversation
elharo
marked this pull request as ready for review
August 4, 2026 12:29
gnodet
approved these changes
Aug 4, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
There was a problem hiding this comment.
Correct and well-scoped. The repo has one ODG file (src/site/xdoc/maven-resolver-deps.odg) which is a binary ZIP archive (OpenDocument Graphics) — it can't carry a license header. The **/*.odg glob is consistent with the existing **/*.key pattern in the RAT config.
This review was generated by an AI agent (Claude Code) and may contain inaccuracies. Please verify all suggestions before applying.
On behalf of gnodet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2028
It is a binary file: While technically a zip archive of XML, OpenDocument formats are meant to be edited via GUI tools (like LibreOffice/OpenOffice), not hand-edited. It is standard practice in Apache projects to treat such rich-document formats as binaries.
License Headers break ODG: You cannot reliably inject standard Apache ALv2 text headers into the XML inside the ODG archive without risking file corruption or breaking the application that reads the ODG file.
Apache Policy: The Apache Software Foundation's policy on license headers explicitly states that files without a degree of creativity (like configuration files or generated diagrams) or binary files where adding a header would break the format do not require ALv2 headers.