Bug: Apache transport deadlock in concurrent use case - #1953
Merged
Conversation
Make sure the class SSLConnectionSocketFactory is initialized early, instead lazily in ConcurrentHashMap.computeIfAbsent, as latter may cause deadlock. Ref: quarkusio/quarkus#55317
gnodet
approved these changes
Jul 8, 2026
gnodet
left a comment
Contributor
There was a problem hiding this comment.
Clean, well-targeted fix for a real deadlock — the pattern (eager class initialization to avoid the documented ConcurrentHashMap.computeIfAbsent hazard) is sound and well-established.
Evaluation:
- Correctness: The JVM guarantees
GlobalState.<clinit>completes before any static/instance members are used, soSSLConnectionSocketFactoryis fully initialized beforecomputeIfAbsentis ever reached. - Sufficiency: A single call to
getDefaultHostnameVerifier()triggersSSLConnectionSocketFactory.<clinit>, which initializes the class once. All three usage points (lines 153, 166, 190) then access an already-initialized class. - Scope: Minimal, focused change — exactly what's needed.
- Tests: No tests added, but acceptable — class-initialization deadlocks are inherently timing-sensitive and non-deterministic.
Minor observation (non-blocking): The comment references the Quarkus PR (quarkus/pull/55345) which is the downstream workaround. Consider also linking to the Quarkus issue (quarkus/issues/55317) which contains the detailed thread-dump and root-cause analysis, for future maintainer context.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure the class SSLConnectionSocketFactory is initialized early, instead lazily in ConcurrentHashMap.computeIfAbsent, as latter may cause deadlock.
Refs: