Repository navigation
Fix Maven 4 @Resolution injection in generated plugin descriptors - #1234
Open
goutamadwant wants to merge 1 commit into
Open
goutamadwant wants to merge 1 commit into
goutamadwant wants to merge 1 commit into
Conversation
Carry resolution annotations through the scanner and descriptor model, then write their field, path scope, and request type to Maven 4 plugin.xml. Extend the Maven 4 integration test to execute a mojo with direct and inherited resolution fields and a real compile dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1230.
A Maven 4 mojo can declare an
@Resolutionfield, but Plugin Tools currently omits it fromplugin.xml. Maven then leaves the field null even when the project has matching dependencies.This change carries the annotated field,
pathScope, andrequestTypethrough scanning and descriptor generation, including fields inherited from a superclass. It writes<resolutions>only for Maven 4 descriptors. Thev4api-4xintegration test checks the generated XML and runs a mojo with direct and inherited resolution fields against a real compile dependency.Validation:
masterwith Maven 4.0.0-rc-7, the plugin builds, but the descriptor has no<resolutions>and goal execution fails because the compile dependency was not injected.v4api-4xintegration test passes with Maven 4.0.0-rc-7 after the fix.mvn -Prun-its verifypasses with Maven 3.9.16 and JDK 21: 32 plugin integration tests pass, one Maven 4 fixture is skipped under Maven 3, and 12 plugin-report integration tests pass.git diff --checkpasses.To make clear that you license your contribution under the Apache License Version 2.0, January 2004, check one of the following: