Skip to content

[MENFORCER-195] Fix to enforcer dependencyConvergence rule to support… - #54

Closed
fbyrne wants to merge 1 commit into
apache:masterfrom
fbyrne:fix-dependency-convergence
Closed

fbyrne wants to merge 1 commit into
apache:masterfrom
fbyrne:fix-dependency-convergence

Conversation

@fbyrne

@fbyrne fbyrne commented Jul 16, 2019

Copy link
Copy Markdown

Hi,
Adding this pull request as a fix for [MENFORCER-195].

Please disregard if the existing PR is sufficient.

Kind regards,
Fergus

@fbyrne

fbyrne commented Jul 16, 2019

Copy link
Copy Markdown
Author

Duplicate of #20

@fbyrne fbyrne closed this Jul 16, 2019
@fbyrne

fbyrne commented Jul 22, 2019

Copy link
Copy Markdown
Author

Reopening as PR #20 is open since 2016 with no activity.

@fbyrne fbyrne reopened this Jul 22, 2019
@rfscholte

Copy link
Copy Markdown
Contributor

I worked together with Ray Tsang on this, after a lot of digging we discovered the real fix requires a change in Maven Core, see apache/maven#269.
This PR doesn't have a test to confirm the fix, #56 does.
So I'll close this one in favor of the other two PRs

@rfscholte rfscholte closed this Jul 22, 2019
@jira-importer

Copy link
Copy Markdown

Resolve #692

1 similar comment
@jira-importer

Copy link
Copy Markdown

Resolve #692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants